Preserve state when a multi-target revocation fails #621
Labels
No labels
bug
cli
core
docs
event
experiment
figure
invariant
metrics
oracle
phase-0
phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
provenance
revocation
tests
workload
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erikinkinen/AES#621
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A failed multi-target revocation can mutate authority state without a corresponding accepted event.
apply_revoke_capcurrently mutates the live EdgeStore in target order. If a later mutation fails, apply_event clears the returned delta but does not roll back earlier mutations.Reproduction on the current source (the affected apply_event.cpp is unchanged from merged main): create two independent Read roots, set the second root's epoch to UINT64_MAX in a controlled test fixture, then use epoch_indirection to revoke both roots. The second bump fails, but the first root's epoch changes from 0 to 1. Engine time/history remain unchanged.
Observed standalone probe output, exit 1:
This violates failed-event state preservation and is also a prerequisite for safely propagating future checked instrumentation errors. No successful legacy event should change its behavior or serialized bytes.