Bug: CI formatter version disagrees with pinned local hooks #635

Closed
opened 2026-10-20 20:33:10 +02:00 by erikinkinen · 0 comments
Owner

Problem

The formatting gate uses two incompatible formatter versions: .pre-commit-config.yaml pins clang-format 18.1.8, but .forgejo/workflows/clang-format.yml installs Debian Bookworm's unpinned clang-format (14). New C++20 template declarations pass all local hooks and fail both remote formatting checks.

Reproduction

At PR #634 head 7cdc6a5b194d5b2c1e94f70fc5f7e2e4e7244a47, local pre-commit run --all-files passes. Forgejo runs 23663 and 23666 reject research/src/event_fields.hpp and research/src/event_log.cpp: macro alignment and empty template-struct brace layout differ. The bounded 18,664-byte failure log is preserved in the execution audit. The source has passed all 62 tests in Debug, Release and Clang ASan/UBSan; the formatting gate must still be corrected and pass before merge.

Steps

  • Preserve the local-versus-CI formatter mismatch evidence and identify the versions.
  • Make CI use the repository-pinned clang-format 18.1.8 and explicitly verify its version.
  • Verify formatting of the affected declarations and the repository, then require all final PR checks before merge.

Acceptance

Local hooks and CI use the same formatter release, with the installed CI version printed and checked. No scientific semantics, test assertions or formatting checks are disabled. Keep this fix in its own signed branch and PR, then integrate it into #634 without rewriting published history.

## Problem The formatting gate uses two incompatible formatter versions: `.pre-commit-config.yaml` pins clang-format 18.1.8, but `.forgejo/workflows/clang-format.yml` installs Debian Bookworm's unpinned `clang-format` (14). New C++20 template declarations pass all local hooks and fail both remote formatting checks. ## Reproduction At PR #634 head `7cdc6a5b194d5b2c1e94f70fc5f7e2e4e7244a47`, local `pre-commit run --all-files` passes. Forgejo runs 23663 and 23666 reject `research/src/event_fields.hpp` and `research/src/event_log.cpp`: macro alignment and empty template-struct brace layout differ. The bounded 18,664-byte failure log is preserved in the execution audit. The source has passed all 62 tests in Debug, Release and Clang ASan/UBSan; the formatting gate must still be corrected and pass before merge. ## Steps - [x] Preserve the local-versus-CI formatter mismatch evidence and identify the versions. - [x] Make CI use the repository-pinned clang-format 18.1.8 and explicitly verify its version. - [x] Verify formatting of the affected declarations and the repository, then require all final PR checks before merge. ## Acceptance Local hooks and CI use the same formatter release, with the installed CI version printed and checked. No scientific semantics, test assertions or formatting checks are disabled. Keep this fix in its own signed branch and PR, then integrate it into #634 without rewriting published history.
erikinkinen added this to the Phase 2 milestone 2026-10-20 20:33:10 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES#635
No description provided.