Bug: CI formatter version disagrees with pinned local hooks #635
Labels
No labels
bug
cli
core
docs
event
experiment
figure
invariant
metrics
oracle
phase-0
phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
provenance
revocation
tests
workload
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erikinkinen/AES#635
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The formatting gate uses two incompatible formatter versions:
.pre-commit-config.yamlpins clang-format 18.1.8, but.forgejo/workflows/clang-format.ymlinstalls Debian Bookworm's unpinnedclang-format(14). New C++20 template declarations pass all local hooks and fail both remote formatting checks.Reproduction
At PR #634 head
7cdc6a5b194d5b2c1e94f70fc5f7e2e4e7244a47, localpre-commit run --all-filespasses. Forgejo runs 23663 and 23666 rejectresearch/src/event_fields.hppandresearch/src/event_log.cpp: macro alignment and empty template-struct brace layout differ. The bounded 18,664-byte failure log is preserved in the execution audit. The source has passed all 62 tests in Debug, Release and Clang ASan/UBSan; the formatting gate must still be corrected and pass before merge.Steps
Acceptance
Local hooks and CI use the same formatter release, with the installed CI version printed and checked. No scientific semantics, test assertions or formatting checks are disabled. Keep this fix in its own signed branch and PR, then integrate it into #634 without rewriting published history.