BUG: moved-holder oracle regression fixture drops delegation indexes #641

Closed
opened 2026-10-20 21:52:06 +02:00 by erikinkinen · 0 comments
Owner

Problem

The independent moved-state fixture added for #638 reconstructs EdgeStore through TestAccess::add_edge. That helper rebuilds holder/object adjacency, but does not rebuild delegation indexes. Moving a root with a surviving child therefore silently changes the topology consulted by eager resolvers. The production move primitive preserves those indexes; this is a regression-fixture defect, not an observed production movement failure.

At main 6f395749f9dae392173d04153f43c71a824b90ce, adding before/after delegation-index equality assertions makes aes_moved_holder_oracle_tests fail with movement fixture erased delegation indexes (CTest exit 8). Logs and JUnit are preserved under /tmp/aes-phase2-execution/moved-oracle-fixture-indexes.

Correction

Now that P2-08-A is merged, use the actual production movement primitive in this fixture. Assert preservation of incoming/delegation indexes and validity markers. Add hand-derived expected residue for all seven withdrawal mechanisms so agreement between the oracle and actual UseCap alone cannot conceal a corrupted resolver topology. Retain binding failures, birth/current-role separation, empty destinations and frozen-cohort checks.

Acceptance

  • Preserve the failing index-preservation regression and correct the fixture with explicit topology, validity and hand-derived mechanism assertions.
  • Validate the unchanged production code plus corrected fixtures in Debug, Release, ASan/UBSan and repository hooks on its own signed branch/PR.
  • Attach before/after evidence, pass all final-head Forgejo checks, then check this checklist once and merge.

Discovered during #98 snapshot-restoration review. Phase 2, milestone 3. No scientific data has been collected; prior #638 production-oracle correction remains applicable.

## Problem The independent moved-state fixture added for #638 reconstructs EdgeStore through TestAccess::add_edge. That helper rebuilds holder/object adjacency, but does not rebuild delegation indexes. Moving a root with a surviving child therefore silently changes the topology consulted by eager resolvers. The production move primitive preserves those indexes; this is a regression-fixture defect, not an observed production movement failure. At main `6f395749f9dae392173d04153f43c71a824b90ce`, adding before/after delegation-index equality assertions makes aes_moved_holder_oracle_tests fail with `movement fixture erased delegation indexes` (CTest exit 8). Logs and JUnit are preserved under `/tmp/aes-phase2-execution/moved-oracle-fixture-indexes`. ## Correction Now that P2-08-A is merged, use the actual production movement primitive in this fixture. Assert preservation of incoming/delegation indexes and validity markers. Add hand-derived expected residue for all seven withdrawal mechanisms so agreement between the oracle and actual UseCap alone cannot conceal a corrupted resolver topology. Retain binding failures, birth/current-role separation, empty destinations and frozen-cohort checks. ## Acceptance - [x] Preserve the failing index-preservation regression and correct the fixture with explicit topology, validity and hand-derived mechanism assertions. - [x] Validate the unchanged production code plus corrected fixtures in Debug, Release, ASan/UBSan and repository hooks on its own signed branch/PR. - [x] Attach before/after evidence, pass all final-head Forgejo checks, then check this checklist once and merge. Discovered during #98 snapshot-restoration review. Phase 2, milestone 3. No scientific data has been collected; prior #638 production-oracle correction remains applicable.
erikinkinen added this to the Phase 2 milestone 2026-10-20 21:52:06 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES#641
No description provided.