WIP: Remove duplicate RTC logging and correct readiness fixtures #3
No reviewers
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/deviced!3
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/posix-compat"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary and rationale
Submit RTC readiness once after successful one-shot completion. The previous admin path made two submissions through the same Logd boundary. Keep the remaining request identity and the completed driver result independent of informational logging failure.
Correct an existing housekeeping fixture uncovered by the expanded release-feature checks. The original fixture queued SERIAL readiness, which already satisfied the ready predicate, while claiming to exercise registration deferral. Separate actual registration deferral from queued SERIAL internal-control delivery and assert each case's real prerequisites.
Tracking and scope
The linked component audit, implementation and consumer requirements remain part of this WIP review. The phase-wide guest and toolchain build requirements stay with the phase completion issue.
Architecture, authority and failure behavior
The only production operation removed is the first duplicate RTC-success Logd submission. RTC preparation, start, waited exit, alias retirement, error ordering and the remaining delegated sender are unchanged. No new production capability, receiver, discovery path or retained authority is introduced. A rejected informational log does not undo completed lifecycle success or restart the one-shot.
Test-only thread-local hooks exercise the actual admin branch and common raw-log entry. They record success/failure ordering, isolate test threads and restore the unarmed path after panic. They do not simulate or prove guest capability retirement. The terminal-start failure path's separate duplicate logs remain an explicit follow-up audit item.
The housekeeping correction changes tests only. One case proves that an unready SERIAL provider keeps its registration receiver selected while an unrelated ready marker remains queued. Another preserves queued SERIAL control when the host lacks a Logd endpoint. Production registration and release-log policies are unchanged.
Validation evidence
Formatting, strict Clippy, warning-denied builds and documentation, unit tests, and applicable native/VM and consumer regressions remain required for the declared scope. Authored controls and older successful runs do not establish current full acceptance.
Review checklist
This review remains WIP until its declared scope and dependent requirements are complete.
erikinkinen referenced this pull request from erix/integration2026-09-12 23:09:39 +02:00
The source changes are now split into #5, #9, #10, #11, #12.
Closing this aggregate PR unmerged as superseded. The replacements preserve all original implementation and documentation, with current CI source routing retained. Provider links and acceptance remain open in the WIP PRs. The original branch is retained for recovery and existing source references.
Pull request closed