generated from erix/meta
[FEATURE] Audit authority, code quality and documentation in drv-virtio-block #1
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/drv-virtio-block#1
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem and motivation
Audit
drv-virtio-blockthroughout Phase 6. Mediate virtio block-device queues and I/O under explicit device/process ownership.Review each changed boundary at the final published revision. Prioritize security, reliability, then performance.
Proposed behavior and scope
Current inventory: 1 Cargo target (1 bin); manifests:
Cargo.toml. Include explicit and automatically discovered targets, supported features and target-specific configurations.Inventory each device/process startup receipt, hardware operation and provider route, then its rejection, restart and teardown paths. Compare test/production grants and justify each hardware bound using the supported device contract.
Authority, security and reliability
Record each finding's affected revision, invariant, reproduction, owner, regression coverage and resolution. Report suspected vulnerabilities through SECURITY.md and keep sensitive details private. Record a result and rationale for each audit criterion, including caller responsibilities when this component has no process or Rust target.
Acceptance criteria
Checklist
missing_docsenforcement without blanket allowances or hidden-API escapes, warning-denied private-item rustdoc and an undocumented-public-API negative gate.cargo fmt --all -- --check, strict Clippy, unit/doctests and warning-denied builds/rustdoc for every owned crate/target under default and all valid feature, freestanding/host, SMP and profile combinations; test mutually exclusive combinations separately. Add focused VM regressions for runtime behavior and observe the older catalog and unit tests at the exact published heads.Alternatives and tradeoffs
Refactor within the component unless shared semantics justify extracting common code. Preserve regression coverage before deleting superseded paths. Profile before optimizing, and document ABI limits, hardware limits and explicit quotas. Preserve security and reliability requirements.
Matching catalog adoption and real consumer VMs remain requirements; complete realm and full in-guest build acceptance remain open.
Original coherent realm source CI acceptance — 18 September 2026: Signed
fa846aabfa08e2000c8d06cf417b44201a15f54apasses CI 58 and CI 57. Coherent catalog publication, actual consumer VMs and full guest-build acceptance remain separate open requirements.Tracking and rollout
All 34 maintained local checks pass: development/release feature matrices (20 unit tests per selection), strict host/native Clippy, warning-denied builds, private rustdoc, applicable doctests and component-specific checks, formatting and exact dependency-source validation. Native binaries have executable read-only entry pages and no writable executable pages. Original CI65 and CI66 pass; their complete logs are independently reviewed with zero warnings. No unchanged CI was rerun. Coordinated VM configuration/seal/four-client I/O, repeated managed-row reuse, profiler observation and both full builds inside EriX remain open under the phase checklist. This dependency work earns no separate feature-completion credit.
All 4 selected development/release configurations pass (20 unit tests per configuration). Strict host/native Clippy, warning-denied host/native builds, doctests where provided, private rustdoc, formatting, Markdown and dependency checks pass with zero warnings.
Matching-image native Posixd startup, two-realm independence and retirement acceptance remain pending. These local checks do not establish sealing, client I/O, a complete EriX guest build or the external toolchain rebuild. Publication CI is tracked separately from local validation.
Runtime consumer dependency alignment — 15 September 2026
The product catalog, product VM acceptance and guest build remain pending.
Full catalog equality and actual consumer-image validation remain required under Integration regression 68. This dependency checkpoint does not close full lifecycle, frame or self-hosting acceptance.
Full service CPU/profiler VM acceptance and guest builds remain open in Phase 6 completion.
Explicit original-device durability barriers — 30 September 2026
LibBlock defines exact receipt-free 16/24-byte flush framing (
0x704), full request/device correlation, atomic encoding, a descriptive support flag and a refusal default. Its client uses only supplied transport and never replays an accepted request. Blockd forwards one admitted whole-disk or partition barrier to its original provider, preserving read-only/unsupported refusal and existing provider-binding retirement. No new capability or data-access route is added.Unknown guarantees refuse.
They cover independent wire evidence, atomic refusal, miscorrelation, no replay, original partition selection, negotiated-feature proof, witness order and failed persistence. Two native VM scenarios exercise the original mounted FAT partition: writable media rewrites original boot bytes, completes the barrier and compares a fresh read; read-only media must refuse without data I/O.
The full status/directory feature remains open for complete FAT metadata and integration; the wider durability item remains open for filesystem recovery, truncate/sparse growth and compatibility fsync/fdatasync. Both full EriX guest build generations and external Rust/LLVM rebuilding inside EriX remain required and unperformed.
Related records and contracts
[FEATURE] [P02.R14] Audit authority, code quality and documentation in drv-virtio-blockto [FEATURE] Audit authority, code quality and documentation in drv-virtio-block