[BUG] Parallel orphan tests share a filesystem checker image #24

Closed
opened 2026-10-14 14:33:45 +02:00 by erikinkinen · 1 comment
Owner

Summary

Two orphan-lifetime tests use the same temporary ext image while running in parallel. One test can overwrite or remove the image while the other runs e2fsck.

Reproduction

Run the normal parallel unit suite at 508790d3b2e730e126905793fadb0eeac92040cf. CI 411 reaches this collision; its frequency is not established. Both affected cases call assert_e2fsck with the label fs-ext3, and the helper names its image using only that label and the process ID.

Expected and actual behavior

Each checker invocation must own a distinct image through checking and removal. Instead, one case reports e2fsck aborted and the other fails to remove the image with ENOENT. The suite finishes with 572 of 574 cases passing in 64.48 seconds.

Environment and identity

Linux 6.14.0-1-pve, x86-64 Docker CI, normal Rust unit-test concurrency. The affected code is the host fixture helper in src/media/truncate_fixture_tests.rs; this does not establish a guest filesystem defect. The last reliably working parallel revision is unknown.

Evidence and prior checks

The linked run retains both failures and their checker output. The previously stalled encrypted-growth cases complete after the AES dependency update. Test serialization and larger time limits would leave this fixture collision unresolved.

Tracking

Repository audit, implementation PR, phase completion.

  • Give each checker invocation its own exclusively created image and retire it after checking.
  • Cover concurrent same-label fixtures while preserving e2fsck assertions and parallel execution.
  • Complete the original repository workflow with the repair.
## Summary Two orphan-lifetime tests use the same temporary ext image while running in parallel. One test can overwrite or remove the image while the other runs e2fsck. ## Reproduction Run the normal parallel unit suite at `508790d3b2e730e126905793fadb0eeac92040cf`. [CI 411](https://git.erikinkinen.fi/erix/e2fsd/actions/runs/411) reaches this collision; its frequency is not established. Both affected cases call `assert_e2fsck` with the label `fs-ext3`, and the helper names its image using only that label and the process ID. ## Expected and actual behavior Each checker invocation must own a distinct image through checking and removal. Instead, one case reports e2fsck aborted and the other fails to remove the image with ENOENT. The suite finishes with 572 of 574 cases passing in 64.48 seconds. ## Environment and identity Linux 6.14.0-1-pve, x86-64 Docker CI, normal Rust unit-test concurrency. The affected code is the host fixture helper in `src/media/truncate_fixture_tests.rs`; this does not establish a guest filesystem defect. The last reliably working parallel revision is unknown. ## Evidence and prior checks The linked run retains both failures and their checker output. The previously stalled encrypted-growth cases complete after the AES dependency update. Test serialization and larger time limits would leave this fixture collision unresolved. ## Tracking [Repository audit](https://git.erikinkinen.fi/erix/e2fsd/issues/1), [implementation PR](https://git.erikinkinen.fi/erix/e2fsd/pulls/3), [phase completion](https://git.erikinkinen.fi/erix/integration/issues/65). - [x] Give each checker invocation its own exclusively created image and retire it after checking. - [x] Cover concurrent same-label fixtures while preserving e2fsck assertions and parallel execution. - [x] Complete the original repository workflow with the repair.
Author
Owner

Each checker invocation now creates its own image exclusively. Concurrent same-label fixtures stay independent; attempts to reuse an existing file or symlink leave it intact. Commit c0b9ce7f passes all 577 tests in CI 415, including both original failures. Closing this fixture race.

Each checker invocation now creates its own image exclusively. Concurrent same-label fixtures stay independent; attempts to reuse an existing file or symlink leave it intact. [Commit c0b9ce7f](https://git.erikinkinen.fi/erix/e2fsd/commit/c0b9ce7fd2e0cb4046b886293c380d43c36bfd5b) passes all 577 tests in [CI 415](https://git.erikinkinen.fi/erix/e2fsd/actions/runs/415), including both original failures. Closing this fixture race.
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:33:47 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/e2fsd#24
No description provided.