[BUG] Frame checker rejects explicit count-one shift spelling #23
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/exsh#23
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The frame checker rejects valid one-bit shifts when the selected disassembler prints the count explicitly. Four sites in the retained CI 578 input lose scalar evidence for this reason.
Reproduction
At
32f08dbd, pass either decoded instruction toprepare_bit_operation:d1e8shr $1,%eax49d1e9shr $1,%r9Both occur twice in the retained runtime/dev root-mode input from CI 578.
Expected and actual behavior
Intel’s shift reference defines D1 /5 as a right shift by one. The checker should accept an equivalent explicit count while retaining its exact opcode, width and destination checks. It instead raises
scalar shift text disagrees with bytes, because that branch accepts only the register-only spelling.Environment and identity
Exsh
32f08dbd14ba7d80d5e76c13fc71047a317818e7, x86-64 runtime/dev root-mode capture. The original CI job expires at its frame deadline; the four refusals are visible in a separate replay of its unchanged captured input. The replay is diagnostic evidence, not a CI pass.Evidence and prior checks
The retained instruction bytes and text agree on a one-bit right shift. The original D1 branch fixes the decoded count to one but compares the operand against
%registeralone. The separate deadline problem remains tracked in #4.Tracking
Published
6cbf7cfcaccepts decimal and hexadecimal explicit count-one spellings for D1 shifts. Six focused regressions pass, covering both widths, all four retained sites, wrong counts/destinations and unchanged C1 behavior. Full-suite coverage is still in progress; the separate frame-analysis deadline remains tracked in #4.The fix is published in
6cbf7cfc. The regression controls recheck all four retained sites, including their scalar transfers, while keeping incorrect counts, destinations and C1 encodings rejected. The full maintained cleanup suite also passes all 1,104 tests.All three criteria are complete. The production frame-analysis deadline remains open in #4; this closure does not claim a complete graph or a CI pass.