[BUG] Realm diagnostic fails strict Clippy #24

Closed
opened 2026-10-17 11:31:48 +02:00 by erikinkinen · 2 comments
Owner

Summary

The realm-directory diagnostic introduces two strict-Clippy failures, stopping
Exsh CI before its unit and frame checks.

Reproduction

At 324b1242, run the maintained Cargo workspace with
cargo clippy --all-targets --all-features -- -D warnings.
Observed in CI 582.

Expected and actual behavior

The uncertain-owner guard must remain nonreturning, and receipt cleanup must
preserve the first scalar error without warnings.

Clippy rejects the empty match around an uninhabited hold callback as unreachable
code (realm_probe.rs:128). It also rejects a map_err used only to observe the
unchanged error (realm_binding_diagnostic.rs:82, manual_inspect). Cargo exits
101 before the existing frame-analysis gate is reached.

Environment and identity

  • Exsh 324b12422dd496310ce136615c3fe694826aa74f.
  • LibIPC 3f24f57e558acf01fc2db3908e7a0c2f1f5d347a.
  • Linux x86-64, Rust 1.93.1, all targets and features, warnings denied.

Evidence and prior checks

CI 582
reports both diagnostics. Its complete original log is retained. The separate
frame-analysis timeouts remain
open; this failed job does not reach them.

Tracking

Related: realm-directory diagnostics
and the implementation.

  • Remove both diagnostics while retaining the original uncertain owners.
  • Complete strict Clippy and the diagnostic custody controls.
  • Confirm the corrected source in CI.
## Summary The realm-directory diagnostic introduces two strict-Clippy failures, stopping Exsh CI before its unit and frame checks. ## Reproduction At `324b1242`, run the maintained Cargo workspace with `cargo clippy --all-targets --all-features -- -D warnings`. Observed in CI 582. ## Expected and actual behavior The uncertain-owner guard must remain nonreturning, and receipt cleanup must preserve the first scalar error without warnings. Clippy rejects the empty match around an uninhabited hold callback as unreachable code (`realm_probe.rs:128`). It also rejects a `map_err` used only to observe the unchanged error (`realm_binding_diagnostic.rs:82`, `manual_inspect`). Cargo exits 101 before the existing frame-analysis gate is reached. ## Environment and identity - Exsh `324b12422dd496310ce136615c3fe694826aa74f`. - LibIPC `3f24f57e558acf01fc2db3908e7a0c2f1f5d347a`. - Linux x86-64, Rust 1.93.1, all targets and features, warnings denied. ## Evidence and prior checks [CI 582](https://git.erikinkinen.fi/erix/exsh/actions/runs/582) reports both diagnostics. Its complete original log is retained. The separate [frame-analysis timeouts](https://git.erikinkinen.fi/erix/exsh/issues/4) remain open; this failed job does not reach them. ## Tracking Related: [realm-directory diagnostics](https://git.erikinkinen.fi/erix/launchd/issues/22) and [the implementation](https://git.erikinkinen.fi/erix/exsh/pulls/3). - [x] Remove both diagnostics while retaining the original uncertain owners. - [x] Complete strict Clippy and the diagnostic custody controls. - [x] Confirm the corrected source in CI.
Author
Owner

e8a9a5e8 fixes both Clippy errors. The custody guard invokes the same nonreturning callback directly, and cleanup records the original error through inspect_err. The owners, held message and first error are preserved. The frame-analysis timeout in #4 remains separate.

`e8a9a5e8` fixes both Clippy errors. The custody guard invokes the same nonreturning callback directly, and cleanup records the original error through `inspect_err`. The owners, held message and first error are preserved. The frame-analysis timeout in #4 remains separate.
Author
Owner

Fixed in e8a9a5e8. Strict Clippy, all six diagnostic custody controls and all 1,035 host tests pass locally and in CI 584. The remaining CI failure is the separately tracked frame-analysis timeout in #4.

Fixed in `e8a9a5e8`. Strict Clippy, all six diagnostic custody controls and all 1,035 host tests pass locally and in [CI 584](https://git.erikinkinen.fi/erix/exsh/actions/runs/584). The remaining CI failure is the separately tracked frame-analysis timeout in #4.
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:33:50 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/exsh#24
No description provided.