[BUG] Realm diagnostic fails strict Clippy #24
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/exsh#24
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The realm-directory diagnostic introduces two strict-Clippy failures, stopping
Exsh CI before its unit and frame checks.
Reproduction
At
324b1242, run the maintained Cargo workspace withcargo clippy --all-targets --all-features -- -D warnings.Observed in CI 582.
Expected and actual behavior
The uncertain-owner guard must remain nonreturning, and receipt cleanup must
preserve the first scalar error without warnings.
Clippy rejects the empty match around an uninhabited hold callback as unreachable
code (
realm_probe.rs:128). It also rejects amap_errused only to observe theunchanged error (
realm_binding_diagnostic.rs:82,manual_inspect). Cargo exits101 before the existing frame-analysis gate is reached.
Environment and identity
324b12422dd496310ce136615c3fe694826aa74f.3f24f57e558acf01fc2db3908e7a0c2f1f5d347a.Evidence and prior checks
CI 582
reports both diagnostics. Its complete original log is retained. The separate
frame-analysis timeouts remain
open; this failed job does not reach them.
Tracking
Related: realm-directory diagnostics
and the implementation.
e8a9a5e8fixes both Clippy errors. The custody guard invokes the same nonreturning callback directly, and cleanup records the original error throughinspect_err. The owners, held message and first error are preserved. The frame-analysis timeout in #4 remains separate.Fixed in
e8a9a5e8. Strict Clippy, all six diagnostic custody controls and all 1,035 host tests pass locally and in CI 584. The remaining CI failure is the separately tracked frame-analysis timeout in #4.