[BUG] OPEN hides publication uncertainty as invalid arguments #16

Closed
opened 2026-10-12 16:33:05 +02:00 by erikinkinen · 1 comment
Owner

Summary

OPEN reports invalid arguments after Fatd has stopped accepting operations because a filesystem write could not be confirmed. The caller loses the terminal publication error.

Reproduction

From Fatd, run:

cargo test --all-targets --all-features uncertain_original_write_poisoning_survives_provider_reset

The fixture loses a completion after a target write, then opens the mounted root directory. It also resets the provider and checks that ordinary operations remain disabled without further device calls.

Expected and actual behavior

OPEN must preserve IPC_RESULT_PUBLICATION_UNCERTAIN (4294967295). The affected code maps every find_mount failure to IPC_RESULT_INVALID_ARGUMENT (2), including the error from a poisoned provider. The reproduced assertion receives Err(2) instead of Err(4294967295).

Environment and identity

Affected: Fatd 21102ceb. The host test injects a lost write completion on its own FAT12 medium.

Evidence and prior checks

The fix maps only a missing mount to invalid arguments and preserves other failures. The regression passes in CI run 288.

Tracking

Related: Fatd PR 3, Phase 6.

## Summary OPEN reports invalid arguments after Fatd has stopped accepting operations because a filesystem write could not be confirmed. The caller loses the terminal publication error. ## Reproduction From Fatd, run: ```sh cargo test --all-targets --all-features uncertain_original_write_poisoning_survives_provider_reset ``` The fixture loses a completion after a target write, then opens the mounted root directory. It also resets the provider and checks that ordinary operations remain disabled without further device calls. ## Expected and actual behavior OPEN must preserve `IPC_RESULT_PUBLICATION_UNCERTAIN` (`4294967295`). The affected code maps every `find_mount` failure to `IPC_RESULT_INVALID_ARGUMENT` (`2`), including the error from a poisoned provider. The reproduced assertion receives `Err(2)` instead of `Err(4294967295)`. ## Environment and identity Affected: [Fatd 21102ceb](https://git.erikinkinen.fi/erix/fatd/commit/21102ceb51e926022baf4b2df802b01cce29c010). The host test injects a lost write completion on its own FAT12 medium. ## Evidence and prior checks [The fix](https://git.erikinkinen.fi/erix/fatd/commit/d6ecf8bd0ff045e125dbe99cfe77588d612dd6f3) maps only a missing mount to invalid arguments and preserves other failures. The regression passes in [CI run 288](https://git.erikinkinen.fi/erix/fatd/actions/runs/288). ## Tracking Related: [Fatd PR 3](https://git.erikinkinen.fi/erix/fatd/pulls/3), [Phase 6](https://git.erikinkinen.fi/erix/integration/issues/65).
Author
Owner

OPEN now preserves terminal publication uncertainty and maps only a missing mount to invalid arguments. Fixed in this commit.

OPEN now preserves terminal publication uncertainty and maps only a missing mount to invalid arguments. Fixed in [this commit](https://git.erikinkinen.fi/erix/fatd/commit/d6ecf8bd0ff045e125dbe99cfe77588d612dd6f3).
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:34:00 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/fatd#16
No description provided.