[BUG] Fixture sender rejects completion after a later stop request #190

Open
opened 2026-10-24 08:47:40 +02:00 by erikinkinen · 0 comments
Owner

Summary

The shared socket fixture sender can accept every command byte and then raise a stop error. A quit command triggers this ordering in the interactive shell transport fixture.

Reproduction

Integration CI3026 host_one reports the sequence-factory error at tests/fixture_socket_io.py:117. FakeGuest handles the complete QMP quit command by setting its stop event; the sender then observes that event after leaving its completed write loop.

Expected and actual behavior

A completed send should retain that result. A stop request must still reject an unsent suffix. The current unconditional stop check after the loop instead turns an already completed command publication into a failure.

Environment and identity

Integration f3d5b32b92, maintained host fixture transport. Current source retains the same post-loop check. No Docker, resource, guest input or original deadline cause is inferred.

Evidence and prior checks

The complete original shard log identifies the post-loop check. Original/current source and the fake guest’s QMP stop behavior are retained. All original partial-write, timeout, cancellation and peer-disconnect requirements remain.

Tracking

Related review: Integration PR12.

  • Keep positive complete-send results ahead of later cooperative stop requests.
  • Preserve refusal and original deadlines when any suffix remains unsent or the peer refuses progress.
  • Cover both orderings and pass the maintained interactive transport controls without relaxing their assertions.
## Summary The shared socket fixture sender can accept every command byte and then raise a stop error. A quit command triggers this ordering in the interactive shell transport fixture. ## Reproduction [Integration CI3026 host_one](https://git.erikinkinen.fi/erix/integration/actions/runs/3026/jobs/2) reports the sequence-factory error at tests/fixture_socket_io.py:117. FakeGuest handles the complete QMP quit command by setting its stop event; the sender then observes that event after leaving its completed write loop. ## Expected and actual behavior A completed send should retain that result. A stop request must still reject an unsent suffix. The current unconditional stop check after the loop instead turns an already completed command publication into a failure. ## Environment and identity Integration f3d5b32b92ab8e5b33a6b76dc9f474ca2f1b8d04, maintained host fixture transport. Current source retains the same post-loop check. No Docker, resource, guest input or original deadline cause is inferred. ## Evidence and prior checks The complete original shard log identifies the post-loop check. Original/current source and the fake guest’s QMP stop behavior are retained. All original partial-write, timeout, cancellation and peer-disconnect requirements remain. ## Tracking Related review: [Integration PR12](https://git.erikinkinen.fi/erix/integration/pulls/12). - [ ] Keep positive complete-send results ahead of later cooperative stop requests. - [ ] Preserve refusal and original deadlines when any suffix remains unsent or the peer refuses progress. - [ ] Cover both orderings and pass the maintained interactive transport controls without relaxing their assertions.
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:34:21 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/integration#190
No description provided.