perf: Retain helper directories during original byte checks #602

Open
erikinkinen wants to merge 1 commit from fix/retained-helper-read-directories into feature/scenario-owned-directory-build
Owner

Repeated helper verification reopened the same full directory ancestry for every byte check. Retain one actual TreeAccess for the defining scripts parent on its original Scope. Register it before admission, verify all retained parent edges on each use and retire it with the Scope.

Each file is still freshly opened, completely read and hashed, checked against its identity and named edge, and closed. Material charges, source guards and all deadlines remain unchanged. Other read roots keep their existing path. Replacement, symlink redirection, failure restoration and partial-admission cleanup have actual FD controls. No successful source proof or file body is cached.

Depends on #598. Ten actual FD controls, seven existing lifecycle/materialization controls and five complete syntax controls passed. The complete helper cohort was refreshed and all seven original owner bodies remain exact. Actual before/after profiling reduced the same runtime-link boundary from 29.39 to 21.49 seconds while retaining all 88 complete source checks. The profiled candidate later reached its original total deadline; that failure is preserved. A separate uninstrumented two-producer native control then passed in 105.62 seconds under the unchanged 120-second limit, with complete retirement. No whole-image, guest or CI pass is claimed.

Repeated helper verification reopened the same full directory ancestry for every byte check. Retain one actual TreeAccess for the defining scripts parent on its original Scope. Register it before admission, verify all retained parent edges on each use and retire it with the Scope. Each file is still freshly opened, completely read and hashed, checked against its identity and named edge, and closed. Material charges, source guards and all deadlines remain unchanged. Other read roots keep their existing path. Replacement, symlink redirection, failure restoration and partial-admission cleanup have actual FD controls. No successful source proof or file body is cached. Depends on #598. Ten actual FD controls, seven existing lifecycle/materialization controls and five complete syntax controls passed. The complete helper cohort was refreshed and all seven original owner bodies remain exact. Actual before/after profiling reduced the same runtime-link boundary from 29.39 to 21.49 seconds while retaining all 88 complete source checks. The profiled candidate later reached its original total deadline; that failure is preserved. A separate uninstrumented two-producer native control then passed in 105.62 seconds under the unchanged 120-second limit, with complete retirement. No whole-image, guest or CI pass is claimed.
erikinkinen added this to the Alpha 1 milestone 2026-11-08 13:15:15 +01:00
perf: Retain helper directories during original byte checks
Some checks failed
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Successful in 9s
CI / rust (push) Failing after 2m10s
Coreutils provider graph / coreutils (push) Successful in 4m19s
CI / native_sources (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_three (push) Has been skipped
CI / host_one (push) Has been skipped
CI / integration (push) Has been skipped
9cb9bad9ca
Repeated helper verification recreated the same complete directory ancestry for every file read. Keep one actual TreeAccess for the defining scripts parent on its original Scope, registered before admission and retired with that Scope.

Continue opening and retiring each file, checking every original byte and named edge, and charging the unchanged material work. Refuse replacement, symlink redirection and failure restoration; preserve partial-acquisition cleanup and all other read roots. Refresh the complete helper cohort without changing the seven original owner bodies.
Some checks failed
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Successful in 9s
CI / rust (push) Failing after 2m10s
Coreutils provider graph / coreutils (push) Successful in 4m19s
CI / native_sources (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_three (push) Has been skipped
CI / host_one (push) Has been skipped
CI / integration (push) Has been skipped
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'fix/retained-helper-read-directories:fix/retained-helper-read-directories'
git switch 'fix/retained-helper-read-directories'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'feature/scenario-owned-directory-build'
git merge --no-ff 'fix/retained-helper-read-directories'
git switch 'fix/retained-helper-read-directories'
git rebase 'feature/scenario-owned-directory-build'
git switch 'feature/scenario-owned-directory-build'
git merge --ff-only 'fix/retained-helper-read-directories'
git switch 'fix/retained-helper-read-directories'
git rebase 'feature/scenario-owned-directory-build'
git switch 'feature/scenario-owned-directory-build'
git merge --no-ff 'fix/retained-helper-read-directories'
git switch 'feature/scenario-owned-directory-build'
git merge --squash 'fix/retained-helper-read-directories'
git switch 'feature/scenario-owned-directory-build'
git merge --ff-only 'fix/retained-helper-read-directories'
git switch 'feature/scenario-owned-directory-build'
git merge 'fix/retained-helper-read-directories'
git push origin 'feature/scenario-owned-directory-build'
Sign in to join this conversation.
No description provided.