fix: Reject malformed runners before helper refresh #691

Open
erikinkinen wants to merge 2 commits from fix/native-helper-runner-syntax into feature/native-build-script-producers
Owner

Parse the defining input runner before scanning the helper inventory or writing declarations. The runner is outside the helper import closure, so a complete inventory alone could miss orphaned binding continuations and other syntax errors.

Keep valid single-line and multiline bindings supported. Add regression controls to CI and the ordered host syntax checks.

Parse the defining input runner before scanning the helper inventory or writing declarations. The runner is outside the helper import closure, so a complete inventory alone could miss orphaned binding continuations and other syntax errors. Keep valid single-line and multiline bindings supported. Add regression controls to CI and the ordered host syntax checks.
erikinkinen added this to the Alpha 1 milestone 2026-11-10 18:15:12 +01:00
fix: Reject malformed runners before refreshing helper declarations
Some checks failed
Markdown / markdown (push) Successful in 27s
CI / cargo_publications (push) Failing after 1m9s
CI / native_sources (push) Has been cancelled
CI / host_zero (push) Has been cancelled
CI / host_one (push) Has been cancelled
CI / host_two (push) Has been cancelled
CI / host_three (push) Has been cancelled
CI / integration (push) Has been cancelled
CI / rust (push) Has been cancelled
Coreutils provider graph / coreutils (push) Has been cancelled
f70ac1ec69
Parse the defining input runner independently of the helper import closure so orphaned binding continuations cannot pass inventory checks or alter declarations.
test: Check generated runner syntax in integration CI
Some checks failed
Markdown / markdown (push) Successful in 32s
CI / cargo_publications (push) Failing after 1m6s
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Coreutils provider graph / coreutils (push) Failing after 2m44s
CI / rust (push) Failing after 5m25s
CI / native_sources (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_one (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_three (push) Has been skipped
CI / integration (push) Has been skipped
02fac806ff
Run the malformed-runner regressions in CI and preserve their complete ordered host syntax command. Document why runner syntax is independent of the helper inventory.
Some checks failed
Markdown / markdown (push) Successful in 32s
CI / cargo_publications (push) Failing after 1m6s
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Coreutils provider graph / coreutils (push) Failing after 2m44s
CI / rust (push) Failing after 5m25s
CI / native_sources (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_one (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_three (push) Has been skipped
CI / integration (push) Has been skipped
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'fix/native-helper-runner-syntax:fix/native-helper-runner-syntax'
git switch 'fix/native-helper-runner-syntax'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'feature/native-build-script-producers'
git merge --no-ff 'fix/native-helper-runner-syntax'
git switch 'fix/native-helper-runner-syntax'
git rebase 'feature/native-build-script-producers'
git switch 'feature/native-build-script-producers'
git merge --ff-only 'fix/native-helper-runner-syntax'
git switch 'fix/native-helper-runner-syntax'
git rebase 'feature/native-build-script-producers'
git switch 'feature/native-build-script-producers'
git merge --no-ff 'fix/native-helper-runner-syntax'
git switch 'feature/native-build-script-producers'
git merge --squash 'fix/native-helper-runner-syntax'
git switch 'feature/native-build-script-producers'
git merge --ff-only 'fix/native-helper-runner-syntax'
git switch 'feature/native-build-script-producers'
git merge 'fix/native-helper-runner-syntax'
git push origin 'feature/native-build-script-producers'
Sign in to join this conversation.
No description provided.