[BUG] Native reply buffers are narrowed before receipt audit #3

Open
opened 2026-10-24 03:38:17 +02:00 by erikinkinen · 1 comment
Owner

Summary

Native broker calls reduce the caller's reply buffer to the minimum normal response size. Two receipt-audit tests consequently panic in their controlled transport instead of reaching the audit.

Reproduction

On a2a8001bc641ec239ab088d15ff29c1f24af5fb3, run the normal CI dependency preparation followed by cargo test --all-targets --all-features.

The failing cases are every_parseable_surplus_receipt_is_attempted_and_first_native_drop_error_survives and release_receipt_disposal_preserves_actual_native_error.

Expected and actual behavior

Keep the caller's full reply storage after checking the minimum request and normal response capacity. Send only the encoded request bytes. Unexpected receipts must remain available for audit and individual disposal before the reply is refused.

The current run passes 21 tests and fails two. The acquisition fixture returns 216 bytes into a slice reduced to 184 bytes; the release fixture returns 96 bytes into a slice reduced to 72 bytes. Both panic at the fake transport's reply copy.

Environment and identity

  • LibCli: a2a8001bc641ec239ab088d15ff29c1f24af5fb3
  • LibStdio: 521f200d4ce97f513a0ece2ef6f8da8e2bc4edad
  • LibIPC: 1841ca496b1d01ab71de8bdec07a91f854ecb688
  • Hosted x86-64 Linux, Rust 1.93.1; no VM or image is involved.
  • The tests supply their own packet storage and controlled receipt observations.

Evidence and prior checks

The original Rust CI failure contains both panics and the 21/2 test summary. Strict Clippy completed before the unit failures.

Tracking

  • Preserve full reply capacity in broker acquisition and release.
  • Check shared stream and exact-file calls for the same restriction.
  • Cover receipt disposal and its first exact failure through those routes.
  • Pass the affected unit cases and current Rust CI.
## Summary Native broker calls reduce the caller's reply buffer to the minimum normal response size. Two receipt-audit tests consequently panic in their controlled transport instead of reaching the audit. ## Reproduction On `a2a8001bc641ec239ab088d15ff29c1f24af5fb3`, run the normal CI dependency preparation followed by `cargo test --all-targets --all-features`. The failing cases are `every_parseable_surplus_receipt_is_attempted_and_first_native_drop_error_survives` and `release_receipt_disposal_preserves_actual_native_error`. ## Expected and actual behavior Keep the caller's full reply storage after checking the minimum request and normal response capacity. Send only the encoded request bytes. Unexpected receipts must remain available for audit and individual disposal before the reply is refused. The current run passes 21 tests and fails two. The acquisition fixture returns 216 bytes into a slice reduced to 184 bytes; the release fixture returns 96 bytes into a slice reduced to 72 bytes. Both panic at the fake transport's reply copy. ## Environment and identity - LibCli: `a2a8001bc641ec239ab088d15ff29c1f24af5fb3` - LibStdio: `521f200d4ce97f513a0ece2ef6f8da8e2bc4edad` - LibIPC: `1841ca496b1d01ab71de8bdec07a91f854ecb688` - Hosted x86-64 Linux, Rust 1.93.1; no VM or image is involved. - The tests supply their own packet storage and controlled receipt observations. ## Evidence and prior checks [The original Rust CI failure](https://git.erikinkinen.fi/erix/lib-cli/actions/runs/28/jobs/0) contains both panics and the 21/2 test summary. Strict Clippy completed before the unit failures. ## Tracking - [x] Preserve full reply capacity in broker acquisition and release. - [x] Check shared stream and exact-file calls for the same restriction. - [x] Cover receipt disposal and its first exact failure through those routes. - [ ] Pass the affected unit cases and current Rust CI.
Author
Owner

Fixed in LibCli c0729043 and LibStdio 4e8de5af. Broker, file and stream calls retain the caller's full reply region while sending only the encoded request bytes. The existing two failing cases are preserved, with additional stream and file receipt controls. Current CI acceptance remains open.

Fixed in [LibCli c0729043](https://git.erikinkinen.fi/erix/lib-cli/commit/c07290430eede5267cbc72d65c407f96dd5ee994) and [LibStdio 4e8de5af](https://git.erikinkinen.fi/erix/lib-stdio/commit/4e8de5af92a4ad5d57996b9a38bd7e008690ff64). Broker, file and stream calls retain the caller's full reply region while sending only the encoded request bytes. The existing two failing cases are preserved, with additional stream and file receipt controls. Current CI acceptance remains open.
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:34:37 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/lib-cli#3
No description provided.