[BUG] Governance tests assume a fixed repository count #5

Closed
opened 2026-10-17 09:34:33 +02:00 by erikinkinen · 1 comment
Owner

Summary

The governance unit suite assumes that the maintained roster has exactly 76
repositories. Registering the owned-region library makes Meta CI fail even
though reviewed repository additions are supported.

Reproduction

At commit 5b2268acbdd9ec25bec2e5c13a8d38b0883d5d7e, run:

python3 -Werror -m unittest discover -s tests -p '*_test.py'

This is the command exercised by the failing governance job in CI 27.

Expected and actual behavior

The maintained roster test should verify required membership and accept reviewed
additions. It should preserve malformed-roster and exact-cohort rejection.

Instead, governance_test.py:306 asserts a count of 76 and reports
AssertionError: 77 != 76. The suite runs 15 tests with one failure and exits 1.

Environment and identity

Meta commit 5b2268acbdd9ec25bec2e5c13a8d38b0883d5d7e, branch
feature/posix-compat, CI 27. The added member is
lib-owned-region.
This is a host-side governance test; no image, VM or runtime grant is involved.

Evidence and prior checks

CI 27 records the exact
assertion failure in its original governance log. The roster parser is not the
reported failure; the unit test stops the job before its roster-check step.

Tracking

Relates to the shared-library proposal
and phase completion.

  • Remove the fixed fleet-size assumption while preserving membership checks.
  • Preserve malformed-input and complete-cohort negative coverage.
  • Restore the governance job on the corrected source.
## Summary The governance unit suite assumes that the maintained roster has exactly 76 repositories. Registering the owned-region library makes Meta CI fail even though reviewed repository additions are supported. ## Reproduction At commit `5b2268acbdd9ec25bec2e5c13a8d38b0883d5d7e`, run: ```sh python3 -Werror -m unittest discover -s tests -p '*_test.py' ``` This is the command exercised by the failing governance job in CI 27. ## Expected and actual behavior The maintained roster test should verify required membership and accept reviewed additions. It should preserve malformed-roster and exact-cohort rejection. Instead, `governance_test.py:306` asserts a count of 76 and reports `AssertionError: 77 != 76`. The suite runs 15 tests with one failure and exits 1. ## Environment and identity Meta commit `5b2268acbdd9ec25bec2e5c13a8d38b0883d5d7e`, branch `feature/posix-compat`, CI 27. The added member is [lib-owned-region](https://git.erikinkinen.fi/erix/lib-owned-region). This is a host-side governance test; no image, VM or runtime grant is involved. ## Evidence and prior checks [CI 27](https://git.erikinkinen.fi/erix/meta/actions/runs/27) records the exact assertion failure in its original governance log. The roster parser is not the reported failure; the unit test stops the job before its roster-check step. ## Tracking Relates to [the shared-library proposal](https://git.erikinkinen.fi/erix/lib-owned-region/issues/1) and [phase completion](https://git.erikinkinen.fi/erix/integration/issues/65). - [x] Remove the fixed fleet-size assumption while preserving membership checks. - [x] Preserve malformed-input and complete-cohort negative coverage. - [x] Restore the governance job on the corrected source.
Author
Owner

Fixed in 8fed04a. The suite now checks an extended original-source cohort without fixing the fleet size. All 16 controls and the 77-member roster check pass locally and in CI 28.

Fixed in [8fed04a](https://git.erikinkinen.fi/erix/meta/commit/8fed04afda4ba68fa39eff7f42e336d619a6b897). The suite now checks an extended original-source cohort without fixing the fleet size. All 16 controls and the 77-member roster check pass locally and in [CI 28](https://git.erikinkinen.fi/erix/meta/actions/runs/28).
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:35:02 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/meta#5
No description provided.