[BUG] Descriptor fixtures retain stale constructor and occupation assumptions #38

Closed
opened 2026-10-03 00:45:12 +02:00 by erikinkinen · 0 comments
Owner

Summary

Descriptor fixtures retained two obsolete assumptions: four pair-allocation constructors omitted explicit subscription storage, and a replacement-undo assertion expected the entire previous descriptor view, including its occupation generation, to return unchanged. The constructor requires four arguments; effect-free undo preserves backend/flags but intentionally never rolls back descriptor occupation generations.

Reproduction

Inspect src/descriptors/acquisition/pair/tests.rs at the reported revision: one multiline and three single-line Table::new calls pass only client count, fd slots and description rows. Compare the four-argument definition in src/descriptors.rs. The pair module includes these fixtures under cfg(test).

A subsequent unit-test compilation should exercise the mismatch. No compiler, unit-test or CI command was run for this report; execution is currently deferred by request. There is no runtime reproduction claim.

Expected and actual behavior

Expected: every fixture supplies its explicit subscription extent, using an empty slice when the fixture owns no readiness subscriptions.

Observed in source: all four pair fixture calls omit that argument. No diagnostic text or exit status was collected, and no native service behavior is inferred from this source defect.

Environment and identity

  • Component repository/revision and Integration source graph: Posixd c77a64b9ceeef5c58bbff1c72f27f3c969582bb9; Integration 756d23c9d0742761a0f932382803bfb983631a99.
  • Image profile, digest and build/runtime configuration: host unit-test source; no image built.
  • Hardware or VM, architecture, firmware and toolchain versions: not exercised; no toolchain-version dependency established.
  • Input/session route and granted authority relevant to reproduction: local supplied descriptor storage; no native authority is acquired.
  • Last known working revision, if known: not established.

Evidence and prior checks

Source-only comparison of four live cfg(test) call sites with the active constructor signature. The narrow correction adds explicit empty subscription storage; the original pair allocation, rollback and publication assertions remain unchanged. No test or CI pass is claimed.

Tracking

Related implementation: local stream sockets, mediator review, phase completion.

Additional source finding — 3 October 2026

The replacement/peer-progress fixture compares its complete restored target View with the pre-replacement View. In contrast, begin_change advances the target occupation generation and undo deliberately preserves that advance. The existing occupation controls explicitly require a different generation after undo. The assertion is updated to require a new occupation while comparing every other field with the original target. This is source evidence; no test was executed.

Complete source resolution — 3 October 2026

The restored-target fixture now requires a distinct occupation generation and compares every remaining field with the original target.

## Summary Descriptor fixtures retained two obsolete assumptions: four pair-allocation constructors omitted explicit subscription storage, and a replacement-undo assertion expected the entire previous descriptor view, including its occupation generation, to return unchanged. The constructor requires four arguments; effect-free undo preserves backend/flags but intentionally never rolls back descriptor occupation generations. ## Reproduction Inspect `src/descriptors/acquisition/pair/tests.rs` at the reported revision: one multiline and three single-line Table::new calls pass only client count, fd slots and description rows. Compare the four-argument definition in `src/descriptors.rs`. The pair module includes these fixtures under cfg(test). A subsequent unit-test compilation should exercise the mismatch. No compiler, unit-test or CI command was run for this report; execution is currently deferred by request. There is no runtime reproduction claim. ## Expected and actual behavior Expected: every fixture supplies its explicit subscription extent, using an empty slice when the fixture owns no readiness subscriptions. Observed in source: all four pair fixture calls omit that argument. No diagnostic text or exit status was collected, and no native service behavior is inferred from this source defect. ## Environment and identity - Component repository/revision and Integration source graph: Posixd `c77a64b9ceeef5c58bbff1c72f27f3c969582bb9`; Integration `756d23c9d0742761a0f932382803bfb983631a99`. - Image profile, digest and build/runtime configuration: host unit-test source; no image built. - Hardware or VM, architecture, firmware and toolchain versions: not exercised; no toolchain-version dependency established. - Input/session route and granted authority relevant to reproduction: local supplied descriptor storage; no native authority is acquired. - Last known working revision, if known: not established. ## Evidence and prior checks Source-only comparison of four live cfg(test) call sites with the active constructor signature. The narrow correction adds explicit empty subscription storage; the original pair allocation, rollback and publication assertions remain unchanged. No test or CI pass is claimed. ## Tracking Related implementation: [local stream sockets](https://git.erikinkinen.fi/erix/posixd/issues/34), [mediator review](https://git.erikinkinen.fi/erix/posixd/pulls/5), [phase completion](https://git.erikinkinen.fi/erix/integration/issues/65). ### Additional source finding — 3 October 2026 The replacement/peer-progress fixture compares its complete restored target View with the pre-replacement View. In contrast, begin_change advances the target occupation generation and undo deliberately preserves that advance. The existing occupation controls explicitly require a different generation after undo. The assertion is updated to require a new occupation while comparing every other field with the original target. This is source evidence; no test was executed. ### Complete source resolution — 3 October 2026 The restored-target fixture now requires a distinct occupation generation and compares every remaining field with the original target.
erikinkinen changed title from [BUG] Pair allocation fixtures omit subscription storage to [BUG] Descriptor fixtures retain stale constructor and occupation assumptions 2026-10-03 00:57:48 +02:00
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:35:08 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/posixd#38
No description provided.