[BUG] Provider cleanup refusal can send a rolled-back lock success #28

Closed
opened 2026-10-04 07:22:38 +02:00 by erikinkinen · 0 comments
Owner

Summary

Source audit confirms that private acquisition-scope cleanup can roll back an original advisory lock change, then refuse provider retirement while leaving its saved success reply available to native serving. The original caller can receive Complete even though its lock is absent. This concerns result consistency for an operation within the original admitted scope.

Reproduction

The smallest source scenario has one original native call; parallel intake is not required:

  1. Admit a scoped file candidate and stage an original Try lock. Save its Complete result without accepting native completion.
  2. Request private retirement using that scope's original cleanup key. Advisory rollback runs, then provider retirement returns Busy. Descriptive receiver metadata remains.
  3. Progress the original native call. The affected implementation can submit its saved Complete result after rollback.

The new control provider_refusal_cannot_publish_the_original_cached_lock_success_after_rollback uses the actual scope/provider fixture, an independent native owner and peer lock observations. It is authored but unrun; no runtime reproduction, frequency or clean-image pass is claimed.

Expected and actual behavior

Expected: beginning authenticated private retirement permanently abandons the original saved result before fallible cleanup. Native history and original provider/receiver/call custody remain retained through positive retirement and disposal.

Actual source behavior: reply abandonment occurs only after provider cleanup succeeds, so a Busy return leaves the saved lock success eligible for COMPLETE despite rollback.

Environment and identity

  • Component repository/revision and Integration source graph: Vfsd 42429aa1, selected by Integration 17f98edd.
  • Image profile, digest and build/runtime configuration: none executed for this report; source and authored fixtures only.
  • Hardware or VM, architecture, firmware and toolchain versions: native x86_64 protocol fixtures; no VM or build execution.
  • Input/session route and granted authority relevant to reproduction: original admitted acquisition scope and file candidate; private cleanup uses the original full scope key.
  • Last known working revision, if known: unknown; this is a source-confirmed defect, not a measured regression.

Evidence and prior checks

The affected retire_acquisition_scope rolls back advisory state before fallible provider cleanup, but suppresses only the receiver row's reply afterward. finish_exact_invocation sees remaining metadata and can attempt that saved result. Authored regression source distinguishes the original native result, peer lock coverage and retained cleanup identity. Additional written controls cover permanent abandonment, original completion history, malformed rosters and multiple-call native/receiver drain. Tests, builds and CI observation remain deferred by request.

Tracking

Independent native invocations, local stream sockets, Phase 6 completion. Related reviews: Vfsd, Docs, Integration.

Regression criteria

  • Permanently abandon every original reply before fallible scope cleanup.
  • Refuse later reply preparation and arbitration while preserving original completion history.
  • Retain provider, receiver and native call custody until positive disposal; preserve independent receivers.
  • Author the minimal serial-call regression and cleanup controls, document and select signed fixes; execution waived by user.

Source repair — 4 October 2026

The full concurrent serving and socket requirements remain open.

## Summary Source audit confirms that private acquisition-scope cleanup can roll back an original advisory lock change, then refuse provider retirement while leaving its saved success reply available to native serving. The original caller can receive Complete even though its lock is absent. This concerns result consistency for an operation within the original admitted scope. ## Reproduction The smallest source scenario has one original native call; parallel intake is not required: 1. Admit a scoped file candidate and stage an original Try lock. Save its Complete result without accepting native completion. 2. Request private retirement using that scope's original cleanup key. Advisory rollback runs, then provider retirement returns Busy. Descriptive receiver metadata remains. 3. Progress the original native call. The affected implementation can submit its saved Complete result after rollback. The new control `provider_refusal_cannot_publish_the_original_cached_lock_success_after_rollback` uses the actual scope/provider fixture, an independent native owner and peer lock observations. It is authored but unrun; no runtime reproduction, frequency or clean-image pass is claimed. ## Expected and actual behavior Expected: beginning authenticated private retirement permanently abandons the original saved result before fallible cleanup. Native history and original provider/receiver/call custody remain retained through positive retirement and disposal. Actual source behavior: reply abandonment occurs only after provider cleanup succeeds, so a Busy return leaves the saved lock success eligible for COMPLETE despite rollback. ## Environment and identity - Component repository/revision and Integration source graph: [Vfsd 42429aa1](https://git.erikinkinen.fi/erix/vfsd/commit/42429aa128e1edda23c80e63398b24fcd5490d10), selected by [Integration 17f98edd](https://git.erikinkinen.fi/erix/integration/commit/17f98edd9ae2af3f026cfeedca92aa47369b1c18). - Image profile, digest and build/runtime configuration: none executed for this report; source and authored fixtures only. - Hardware or VM, architecture, firmware and toolchain versions: native x86_64 protocol fixtures; no VM or build execution. - Input/session route and granted authority relevant to reproduction: original admitted acquisition scope and file candidate; private cleanup uses the original full scope key. - Last known working revision, if known: unknown; this is a source-confirmed defect, not a measured regression. ## Evidence and prior checks The affected `retire_acquisition_scope` rolls back advisory state before fallible provider cleanup, but suppresses only the receiver row's reply afterward. `finish_exact_invocation` sees remaining metadata and can attempt that saved result. [Authored regression source](https://git.erikinkinen.fi/erix/vfsd/src/branch/feature/posix-compat/src/acquisition_scope/lock_scope_drain_tests.rs) distinguishes the original native result, peer lock coverage and retained cleanup identity. Additional written controls cover permanent abandonment, original completion history, malformed rosters and multiple-call native/receiver drain. Tests, builds and CI observation remain deferred by request. ## Tracking [Independent native invocations](https://git.erikinkinen.fi/erix/vfsd/issues/27), [local stream sockets](https://git.erikinkinen.fi/erix/posixd/issues/34), [Phase 6 completion](https://git.erikinkinen.fi/erix/integration/issues/65). Related reviews: [Vfsd](https://git.erikinkinen.fi/erix/vfsd/pulls/3), [Docs](https://git.erikinkinen.fi/erix/docs/pulls/4), [Integration](https://git.erikinkinen.fi/erix/integration/pulls/12). ## Regression criteria - [x] Permanently abandon every original reply before fallible scope cleanup. - [x] Refuse later reply preparation and arbitration while preserving original completion history. - [x] Retain provider, receiver and native call custody until positive disposal; preserve independent receivers. - [x] Author the minimal serial-call regression and cleanup controls, document and select signed fixes; execution waived by user. ### Source repair — 4 October 2026 The full concurrent serving and socket requirements remain open.
erikinkinen 2026-10-04 07:22:38 +02:00
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:35:19 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/vfsd#28
No description provided.