Fix Phase 1 figure loading for relative sweep output paths #612

Closed
opened 2026-10-20 16:02:56 +02:00 by erikinkinen · 0 comments
Owner

Goal

Allow the documented relative-output sweep/figure workflow to locate its own artifacts.

Reproduction

On baseline 6ad94c4, run the smoke sweeps with --out-dir student_t/raw/<dataset> from a temporary working directory, then run tools/regen-figures.sh student_t/raw student_t/figures. The sweep records working-directory-relative paths such as student_t/raw/cost_completeness/runs/r000001/metrics_v2.json; resolve_data_path prefixes the dataset directory again and the figure command exits 1 with a missing-file error.

Discovered during P2-02 (#85). The pinned baseline archive uses absolute paths and retains the original plotting implementation.

Steps

  • Resolve both dataset-relative artifact paths and the working-directory-relative paths emitted by sweeps, rejecting ambiguous different existing candidates.
  • Add regression coverage for both relative conventions, absolute paths, ambiguity and the actual relative-output sweep/figure workflow.
  • Pass figure tests and all required CI checks; preserve existing figure/statistical calculations.

Done

The relative-output workflow generates the same figure content as the absolute-output workflow. Existing dataset-relative archives remain supported and ambiguous paths cannot silently select different evidence.

## Goal Allow the documented relative-output sweep/figure workflow to locate its own artifacts. ## Reproduction On baseline 6ad94c4, run the smoke sweeps with `--out-dir student_t/raw/<dataset>` from a temporary working directory, then run `tools/regen-figures.sh student_t/raw student_t/figures`. The sweep records working-directory-relative paths such as `student_t/raw/cost_completeness/runs/r000001/metrics_v2.json`; `resolve_data_path` prefixes the dataset directory again and the figure command exits 1 with a missing-file error. Discovered during P2-02 (#85). The pinned baseline archive uses absolute paths and retains the original plotting implementation. ## Steps - [x] Resolve both dataset-relative artifact paths and the working-directory-relative paths emitted by sweeps, rejecting ambiguous different existing candidates. - [x] Add regression coverage for both relative conventions, absolute paths, ambiguity and the actual relative-output sweep/figure workflow. - [x] Pass figure tests and all required CI checks; preserve existing figure/statistical calculations. ## Done The relative-output workflow generates the same figure content as the absolute-output workflow. Existing dataset-relative archives remain supported and ambiguous paths cannot silently select different evidence.
erikinkinen added this to the Phase 2 milestone 2026-10-20 16:02:56 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES#612
No description provided.