Phase 2: Resolve relative figure artifact paths (#612) #613

Merged
erikinkinen merged 1 commit from phase2/bug-612-relative-figure-paths into main 2026-10-20 16:11:12 +02:00
Owner

Task

Closes #612

Summary

A sweep using --out-dir raw/cost_completeness writes working-directory-relative artifact paths. The plot reader previously prefixed the dataset directory again, so the documented relative-output workflow failed. Resolve both supported relative conventions and reject paths that name two different existing files.

Scope

Update artifact path resolution and its regression tests. Absolute paths and dataset-relative archives retain their behavior. Statistical calculations, graph semantics and serialized data are unchanged.

Design intent

Keep artifact selection explicit when both path conventions could resolve. Extend the actual sweep/figure smoke test to generate relative and absolute datasets and compare every declared figure, tie-group and pairwise CSV checksum.

Phase discipline

Defect found during P2-02 (#85); the pinned baseline capture continues using the original plot script with absolute paths.

Verification

  • New path regression fails against the original reader and passes with this change.
  • All 16 figure unit tests passed.
  • Relative sweep generation, repeated rendering, absolute generation and full output hash comparison passed.
  • Validation record.
  • Signed commit, formatting and actual commit/push hooks passed. All required CI checks must pass before merge.
# Task Closes #612 ## Summary A sweep using `--out-dir raw/cost_completeness` writes working-directory-relative artifact paths. The plot reader previously prefixed the dataset directory again, so the documented relative-output workflow failed. Resolve both supported relative conventions and reject paths that name two different existing files. ## Scope Update artifact path resolution and its regression tests. Absolute paths and dataset-relative archives retain their behavior. Statistical calculations, graph semantics and serialized data are unchanged. ## Design intent Keep artifact selection explicit when both path conventions could resolve. Extend the actual sweep/figure smoke test to generate relative and absolute datasets and compare every declared figure, tie-group and pairwise CSV checksum. ## Phase discipline Defect found during P2-02 (#85); the pinned baseline capture continues using the original plot script with absolute paths. ## Verification - New path regression fails against the original reader and passes with this change. - All 16 figure unit tests passed. - Relative sweep generation, repeated rendering, absolute generation and full output hash comparison passed. - [Validation record](https://git.erikinkinen.fi/attachments/a4a710a3-c0ac-4172-9afd-4f5ab46ee746). - Signed commit, formatting and actual commit/push hooks passed. All required CI checks must pass before merge.
erikinkinen added this to the Phase 2 milestone 2026-10-20 16:08:07 +02:00
Phase 2: Resolve relative figure artifact paths (#612)
All checks were successful
clang-format / check-format (pull_request) Successful in 25s
markdownlint / markdown-lint (pull_request) Successful in 24s
ci / smoke (pull_request) Successful in 2m39s
markdownlint / markdown-lint (push) Successful in 11s
clang-format / check-format (push) Successful in 12s
ci / smoke (push) Successful in 2m3s
948f39f60a
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES!613
No description provided.