Phase 2: Propagate sanitizer instrumentation to consumers (#614) #616
No reviewers
Labels
No labels
bug
cli
core
docs
event
experiment
figure
invariant
metrics
oracle
phase-0
phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
provenance
revocation
tests
workload
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erikinkinen/AES!616
Loading…
Reference in a new issue
No description provided.
Delete branch "phase2/bug-614-sanitizer-consumers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task
Closes #614
Summary
Enabling ASan/UBSan instrumented AES static libraries but did not propagate their runtime linkage to tests. Even
aes_smoketestfailed to link. Make sanitizer compile/link options public usage requirements so consumers are instrumented and link the required runtimes.Scope
Only
cmake/Sanitizers.cmakechanges. Consumer translation units receive the same instrumentation as their libraries. Default builds retain their current options.Design intent
Attach sanitizer requirements to the targets that need them, covering executable consumers and their instantiated headers without manual flags at each test target.
Phase discipline
Infrastructure defect found during Phase 2 validation. Legacy semantics and serialized artifacts remain byte-identical.
Verification
node:20-bookwormimage, running locally: all 45 CTests passed. No manual sanitizer compiler/linker flags were supplied.Runtime boundary
The old GCC sanitizer runtime stalls on this particular remote runner and emits repeated startup
DEADLYSIGNALmessages. The failed-run evidence and modern-runtime CI integration are separately tracked in #617. This PR validates the target-propagation fix; it does not claim that runner-specific failure is resolved.