Phase 2: Propagate sanitizer instrumentation to consumers (#614) #616

Merged
erikinkinen merged 3 commits from phase2/bug-614-sanitizer-consumers into main 2026-10-20 16:50:45 +02:00
Owner

Task

Closes #614

Summary

Enabling ASan/UBSan instrumented AES static libraries but did not propagate their runtime linkage to tests. Even aes_smoketest failed to link. Make sanitizer compile/link options public usage requirements so consumers are instrumented and link the required runtimes.

Scope

Only cmake/Sanitizers.cmake changes. Consumer translation units receive the same instrumentation as their libraries. Default builds retain their current options.

Design intent

Attach sanitizer requirements to the targets that need them, covering executable consumers and their instantiated headers without manual flags at each test target.

Phase discipline

Infrastructure defect found during Phase 2 validation. Legacy semantics and serialized artifacts remain byte-identical.

Verification

  • Original baseline with sanitizers enabled fails at smoke-test linkage with missing ASan symbols.
  • Fresh Clang 22 ASan/UBSan Debug build: all 45 CTests passed; 44 test translation units carry sanitizer flags; both runtime symbol sets verified in the golden fixture executable.
  • Fresh GCC 16 ordinary Release build: all 45 CTests passed.
  • GCC 12 ASan/UBSan inside the CI's official node:20-bookworm image, running locally: all 45 CTests passed. No manual sanitizer compiler/linker flags were supplied.
  • The same 31 legacy golden cases pass in every configuration.
  • Original reproduction and Clang/Release evidence; complete GCC 12 container evidence.
  • All local hooks and signed commit/push checks passed. All six required Forgejo checks must pass at the final head before merge.

Runtime boundary

The old GCC sanitizer runtime stalls on this particular remote runner and emits repeated startup DEADLYSIGNAL messages. The failed-run evidence and modern-runtime CI integration are separately tracked in #617. This PR validates the target-propagation fix; it does not claim that runner-specific failure is resolved.

# Task Closes #614 ## Summary Enabling ASan/UBSan instrumented AES static libraries but did not propagate their runtime linkage to tests. Even `aes_smoketest` failed to link. Make sanitizer compile/link options public usage requirements so consumers are instrumented and link the required runtimes. ## Scope Only `cmake/Sanitizers.cmake` changes. Consumer translation units receive the same instrumentation as their libraries. Default builds retain their current options. ## Design intent Attach sanitizer requirements to the targets that need them, covering executable consumers and their instantiated headers without manual flags at each test target. ## Phase discipline Infrastructure defect found during Phase 2 validation. Legacy semantics and serialized artifacts remain byte-identical. ## Verification - Original baseline with sanitizers enabled fails at smoke-test linkage with missing ASan symbols. - Fresh Clang 22 ASan/UBSan Debug build: all 45 CTests passed; 44 test translation units carry sanitizer flags; both runtime symbol sets verified in the golden fixture executable. - Fresh GCC 16 ordinary Release build: all 45 CTests passed. - GCC 12 ASan/UBSan inside the CI's official `node:20-bookworm` image, running locally: all 45 CTests passed. No manual sanitizer compiler/linker flags were supplied. - The same 31 legacy golden cases pass in every configuration. - [Original reproduction and Clang/Release evidence](https://git.erikinkinen.fi/attachments/f3304d47-93bc-4a66-99e1-5b92f54b3c81); [complete GCC 12 container evidence](https://git.erikinkinen.fi/attachments/66c2cebd-01ae-42b3-a423-552e3e8137c0). - All local hooks and signed commit/push checks passed. All six required Forgejo checks must pass at the final head before merge. ## Runtime boundary The old GCC sanitizer runtime stalls on this particular remote runner and emits repeated startup `DEADLYSIGNAL` messages. The failed-run evidence and modern-runtime CI integration are separately tracked in #617. This PR validates the target-propagation fix; it does not claim that runner-specific failure is resolved.
erikinkinen added this to the Phase 2 milestone 2026-10-20 16:25:33 +02:00
Phase 2: Propagate sanitizer instrumentation to consumers (#614)
Some checks failed
markdownlint / markdown-lint (push) Successful in 11s
clang-format / check-format (push) Successful in 15s
markdownlint / markdown-lint (pull_request) Successful in 15s
clang-format / check-format (pull_request) Successful in 15s
ci / smoke (push) Has been cancelled
ci / smoke (pull_request) Has been cancelled
b3c0a348f2
Phase 2: Bound sanitizer CI tests and capture diagnostics (#614)
Some checks failed
markdownlint / markdown-lint (pull_request) Successful in 19s
markdownlint / markdown-lint (push) Successful in 19s
clang-format / check-format (pull_request) Successful in 20s
clang-format / check-format (push) Successful in 21s
ci / smoke (pull_request) Failing after 6m13s
ci / smoke (push) Failing after 6m12s
5d600ec729
Phase 2: Track sanitizer runner integration separately in #617 (#614)
All checks were successful
markdownlint / markdown-lint (pull_request) Successful in 16s
clang-format / check-format (pull_request) Successful in 17s
ci / smoke (pull_request) Successful in 2m51s
markdownlint / markdown-lint (push) Successful in 12s
clang-format / check-format (push) Successful in 14s
ci / smoke (push) Successful in 2m2s
83157db0ed
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES!616
No description provided.