Fix CI formatter version drift from local hooks #636
No reviewers
Labels
No labels
bug
cli
core
docs
event
experiment
figure
invariant
metrics
oracle
phase-0
phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
provenance
revocation
tests
workload
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erikinkinen/AES!636
Loading…
Reference in a new issue
No description provided.
Delete branch "phase2/bug-635-formatter-version"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task
Closes #635.
Summary
The local formatter hook pins 18.1.8, while the CI image installed 14.0.6 and rejected compliant C++20 declarations. Read the version from
.pre-commit-config.yaml, install that exact package into an isolated environment, and verify its reported version before running the existing byte-comparison gate.Scope
Only the formatting workflow and its documentation change. A future hook-pin update automatically selects the same CI formatter. Installation failures, version mismatches and formatting differences still fail the job.
Design intent
Use one version authority for local and remote checks. Preserve the formatting checks and avoid rewriting valid source to satisfy incompatible tool versions.
Phase discipline
A separately reproduced tooling regression discovered while validating P2-07-B. No research semantics or scientific result changes.
Verification
At signed fix source
370375031596f44b9692c14d35997a51f09371e7, all eight local hooks pass. clang-format 18.1.8 leaves all 144 tracked source files unchanged and also leaves both failing files extracted from PR #634 head7cdc6a5b194d5b2c1e94f70fc5f7e2e4e7244a47unchanged. The archived CI failure log identifies Debian clang-format 14.0.6 and the conflicting output. Full final-head CI must pass before merge.Reproduction and validation evidence (SHA-256
f73234a2deee3b0686635f1b85d43a92aeff35ab4c1b42f13a5276659252deb3).