Fix CI formatter version drift from local hooks #636

Merged
erikinkinen merged 1 commit from phase2/bug-635-formatter-version into main 2026-10-20 20:42:45 +02:00
Owner

Task

Closes #635.

Summary

The local formatter hook pins 18.1.8, while the CI image installed 14.0.6 and rejected compliant C++20 declarations. Read the version from .pre-commit-config.yaml, install that exact package into an isolated environment, and verify its reported version before running the existing byte-comparison gate.

Scope

Only the formatting workflow and its documentation change. A future hook-pin update automatically selects the same CI formatter. Installation failures, version mismatches and formatting differences still fail the job.

Design intent

Use one version authority for local and remote checks. Preserve the formatting checks and avoid rewriting valid source to satisfy incompatible tool versions.

Phase discipline

A separately reproduced tooling regression discovered while validating P2-07-B. No research semantics or scientific result changes.

Verification

At signed fix source 370375031596f44b9692c14d35997a51f09371e7, all eight local hooks pass. clang-format 18.1.8 leaves all 144 tracked source files unchanged and also leaves both failing files extracted from PR #634 head 7cdc6a5b194d5b2c1e94f70fc5f7e2e4e7244a47 unchanged. The archived CI failure log identifies Debian clang-format 14.0.6 and the conflicting output. Full final-head CI must pass before merge.

Reproduction and validation evidence (SHA-256 f73234a2deee3b0686635f1b85d43a92aeff35ab4c1b42f13a5276659252deb3).

## Task Closes #635. ## Summary The local formatter hook pins 18.1.8, while the CI image installed 14.0.6 and rejected compliant C++20 declarations. Read the version from `.pre-commit-config.yaml`, install that exact package into an isolated environment, and verify its reported version before running the existing byte-comparison gate. ## Scope Only the formatting workflow and its documentation change. A future hook-pin update automatically selects the same CI formatter. Installation failures, version mismatches and formatting differences still fail the job. ## Design intent Use one version authority for local and remote checks. Preserve the formatting checks and avoid rewriting valid source to satisfy incompatible tool versions. ## Phase discipline A separately reproduced tooling regression discovered while validating P2-07-B. No research semantics or scientific result changes. ## Verification At signed fix source `370375031596f44b9692c14d35997a51f09371e7`, all eight local hooks pass. clang-format 18.1.8 leaves all 144 tracked source files unchanged and also leaves both failing files extracted from PR #634 head `7cdc6a5b194d5b2c1e94f70fc5f7e2e4e7244a47` unchanged. The archived CI failure log identifies Debian clang-format 14.0.6 and the conflicting output. Full final-head CI must pass before merge. [Reproduction and validation evidence](https://git.erikinkinen.fi/attachments/7c695cd6-06ed-43b9-b190-88c16bc957f1) (SHA-256 `f73234a2deee3b0686635f1b85d43a92aeff35ab4c1b42f13a5276659252deb3`).
erikinkinen added this to the Phase 2 milestone 2026-10-20 20:34:46 +02:00
Align CI formatting with repository-pinned clang-format (fixes #635)
Some checks failed
clang-format / check-format (pull_request) Successful in 48s
markdownlint / markdown-lint (pull_request) Successful in 27s
ci / sanitizers (pull_request) Successful in 7m10s
ci / smoke (pull_request) Successful in 7m41s
markdownlint / markdown-lint (push) Successful in 25s
clang-format / check-format (push) Successful in 43s
ci / sanitizers (push) Has been cancelled
ci / smoke (push) Has been cancelled
3703750315
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES!636
No description provided.