Phase 2: serialize primary and diagnostic decision ledgers #672

Open
erikinkinen wants to merge 19 commits from phase2/p2-14-e-decision-ledgers into main
Owner

Task

Closes #120. Plan ID: P2-14-E; scientific protocol 2.2, backlog 2.2.1.

Summary

Add the common closed decision-table contract and separate primary/diagnostic
ledgers. Every analysis retains all eight C and fifteen V IDs, explicit
missingness, source/population/seed counts, ordinary and adjusted intervals,
qualification/invariant references, provenance, decisions and machine reasons.
C6b retains twelve component intervals and requires all six sources; its
recall and false-alarm rows have separate estimands and strict/inclusive margins.
Ordinary intervals never determine primary decisions.

The serializer classifies supplied evidence and verifies referenced file bytes.
It does not compute or mathematically qualify primary bounds, validate upstream
scientific estimands, collect production outcomes or certify novelty. P2-28 and
P2-24 retain their inference implementation and qualification obligations.

Scope and design intent

Preserve the frozen ID/margin/source registry, C3b strict noninferiority,
C4b invariant gate, C6a/c equal-source conditional AP means and eligibility,
and C6b six-source conjunction with onset minima and positive denominators.
Reject nonfinite/boolean estimates, missing seeds, unsupported populations,
incorrect interval supports, altered output conclusions and malformed schemas.
Untyped or unavailable evidence stays explicit and cannot become a favorable
result. Existing output files cannot be overwritten.

This PR is queued behind #669 at
128fb39b072ed39fdb5e517775089c8b230a963e. The selected predecessor must be
accepted, its signed merge and saved ten-context CI verified, and all ten own
final contexts passed before the single checklist update and guarded merge.
Native prerequisite #118 is closed. The pending integration does not imply
predecessor or issue acceptance.

Verification

  • Exact source cbac4273ae1d2b48d8feb9f515fee5cdb1d7979f passed all 298 tests
    without skips in Release, assertion-enabled Debug -g -O1, and Clang
    ASan/UBSan. The 36-row synthetic fixture and its complete validation report
    are byte-identical across those profiles and the verified pinned analysis
    image. Fixtures include 25 malformed-input cases, boundary/zero/tie cases,
    all six source gates, evidence-file tampering and output recomputation.
  • Complete source validation,
    SHA-256 7e8bbc4e6f8a9d5970210ee7d4f5c429abb64747a61be92b353931ece8ea8a92.
  • Exact integration f83efe331f127be462f3fba4f3428a10026ab5bd passed the full
    498-test Release suite, with no failures or skips. The inventory is exactly
    the union of 298 source tests and 497 predecessor tests. Owned source bytes
    are unchanged; only the shared tests/CMakeLists.txt hash is superseded by
    the explicit union. Every other predecessor file is retained identically.
  • Complete integration evidence,
    SHA-256 61c0ba497062d8f714fe2794e2093375a5002d6676938a2578072efdad8ec50d.
    The upload response timed out; read-only lookup and download hashing verified
    the already-created asset. No upload POST was repeated.
  • All eight repository hooks and the frozen eleven-PDF/specification scope
    check passed. Only acceptance/integration JSON receipts changed after the
    exact integration execution source; final remote tests run this PR head.

No local full-498 Debug/sanitizer run, production campaign, mathematical bound
qualification, independent scholarly review or journal-readiness claim is made.

# Task Closes #120. Plan ID: `P2-14-E`; scientific protocol 2.2, backlog 2.2.1. ## Summary Add the common closed decision-table contract and separate primary/diagnostic ledgers. Every analysis retains all eight C and fifteen V IDs, explicit missingness, source/population/seed counts, ordinary and adjusted intervals, qualification/invariant references, provenance, decisions and machine reasons. C6b retains twelve component intervals and requires all six sources; its recall and false-alarm rows have separate estimands and strict/inclusive margins. Ordinary intervals never determine primary decisions. The serializer classifies supplied evidence and verifies referenced file bytes. It does not compute or mathematically qualify primary bounds, validate upstream scientific estimands, collect production outcomes or certify novelty. P2-28 and P2-24 retain their inference implementation and qualification obligations. ## Scope and design intent Preserve the frozen ID/margin/source registry, C3b strict noninferiority, C4b invariant gate, C6a/c equal-source conditional AP means and eligibility, and C6b six-source conjunction with onset minima and positive denominators. Reject nonfinite/boolean estimates, missing seeds, unsupported populations, incorrect interval supports, altered output conclusions and malformed schemas. Untyped or unavailable evidence stays explicit and cannot become a favorable result. Existing output files cannot be overwritten. This PR is queued behind #669 at `128fb39b072ed39fdb5e517775089c8b230a963e`. The selected predecessor must be accepted, its signed merge and saved ten-context CI verified, and all ten own final contexts passed before the single checklist update and guarded merge. Native prerequisite #118 is closed. The pending integration does not imply predecessor or issue acceptance. ## Verification - Exact source `cbac4273ae1d2b48d8feb9f515fee5cdb1d7979f` passed all 298 tests without skips in Release, assertion-enabled Debug `-g -O1`, and Clang ASan/UBSan. The 36-row synthetic fixture and its complete validation report are byte-identical across those profiles and the verified pinned analysis image. Fixtures include 25 malformed-input cases, boundary/zero/tie cases, all six source gates, evidence-file tampering and output recomputation. - [Complete source validation](https://git.erikinkinen.fi/attachments/bdc162b0-9114-47d7-896c-9e741e18b2fa), SHA-256 `7e8bbc4e6f8a9d5970210ee7d4f5c429abb64747a61be92b353931ece8ea8a92`. - Exact integration `f83efe331f127be462f3fba4f3428a10026ab5bd` passed the full 498-test Release suite, with no failures or skips. The inventory is exactly the union of 298 source tests and 497 predecessor tests. Owned source bytes are unchanged; only the shared tests/CMakeLists.txt hash is superseded by the explicit union. Every other predecessor file is retained identically. - [Complete integration evidence](https://git.erikinkinen.fi/attachments/05a7c921-7129-47d7-a630-ab4f0a1f4b06), SHA-256 `61c0ba497062d8f714fe2794e2093375a5002d6676938a2578072efdad8ec50d`. The upload response timed out; read-only lookup and download hashing verified the already-created asset. No upload POST was repeated. - All eight repository hooks and the frozen eleven-PDF/specification scope check passed. Only acceptance/integration JSON receipts changed after the exact integration execution source; final remote tests run this PR head. No local full-498 Debug/sanitizer run, production campaign, mathematical bound qualification, independent scholarly review or journal-readiness claim is made.
erikinkinen added this to the Phase 2 milestone 2026-10-30 06:15:28 +01:00
# Conflicts:
#	research/CMakeLists.txt
Phase 2: record canonical run-manifest integration evidence
Some checks failed
clang-format / check-format (push) Successful in 2m3s
formal / definitions (push) Successful in 2m49s
markdownlint / markdown-lint (push) Successful in 1m4s
clang-format / check-format (pull_request) Successful in 1m52s
formal / definitions (pull_request) Successful in 3m7s
markdownlint / markdown-lint (pull_request) Successful in 1m10s
ci / smoke (push) Successful in 41m3s
ci / smoke (pull_request) Successful in 41m51s
ci / sanitizers (push) Failing after 1h30m16s
ci / sanitizers (pull_request) Failing after 1h30m8s
fcbbdf6d08
BUG-666: record source-preserving integration evidence
Some checks failed
clang-format / check-format (push) Successful in 1m45s
markdownlint / markdown-lint (push) Successful in 1m12s
formal / definitions (push) Successful in 2m59s
ci / sanitizers (push) Has been cancelled
ci / smoke (push) Has been cancelled
ci / smoke (pull_request) Has been cancelled
ci / sanitizers (pull_request) Has been cancelled
clang-format / check-format (pull_request) Has been cancelled
formal / definitions (pull_request) Has been cancelled
markdownlint / markdown-lint (pull_request) Has been cancelled
a214b01cbc
BUG-666: complete required archived command inventory
Some checks failed
clang-format / check-format (push) Successful in 1m27s
clang-format / check-format (pull_request) Successful in 1m26s
formal / definitions (push) Successful in 2m32s
markdownlint / markdown-lint (push) Successful in 1m19s
markdownlint / markdown-lint (pull_request) Successful in 1m20s
formal / definitions (pull_request) Successful in 3m1s
ci / smoke (push) Successful in 39m7s
ci / smoke (pull_request) Successful in 38m51s
ci / sanitizers (push) Failing after 1h30m8s
ci / sanitizers (pull_request) Failing after 1h30m5s
8712d6b0dd
Phase 2: integrate validated sanitizer budget into run manifests
All checks were successful
markdownlint / markdown-lint (pull_request) Successful in 38s
markdownlint / markdown-lint (push) Successful in 39s
clang-format / check-format (pull_request) Successful in 59s
clang-format / check-format (push) Successful in 1m3s
formal / definitions (push) Successful in 2m23s
formal / definitions (pull_request) Successful in 2m25s
ci / smoke (pull_request) Successful in 40m7s
ci / smoke (push) Successful in 41m41s
ci / sanitizers (pull_request) Successful in 2h16m9s
ci / sanitizers (push) Successful in 2h16m30s
145abd989a
Phase 2: integrate sanitizer budget into protocol enum correction
All checks were successful
clang-format / check-format (push) Successful in 1m8s
formal / definitions (push) Successful in 2m15s
markdownlint / markdown-lint (push) Successful in 51s
clang-format / check-format (pull_request) Successful in 1m10s
markdownlint / markdown-lint (pull_request) Successful in 1m2s
formal / definitions (pull_request) Successful in 2m36s
ci / smoke (push) Successful in 40m45s
ci / smoke (pull_request) Successful in 40m33s
ci / sanitizers (push) Successful in 2h15m58s
ci / sanitizers (pull_request) Successful in 2h15m31s
128fb39b07
Phase 2: record complete decision-ledger stack integration (#120)
All checks were successful
clang-format / check-format (push) Successful in 1m3s
clang-format / check-format (pull_request) Successful in 50s
markdownlint / markdown-lint (push) Successful in 28s
markdownlint / markdown-lint (pull_request) Successful in 33s
formal / definitions (push) Successful in 2m14s
formal / definitions (pull_request) Successful in 2m9s
ci / smoke (push) Successful in 39m11s
ci / smoke (pull_request) Successful in 38m7s
ci / sanitizers (push) Successful in 2h5m18s
ci / sanitizers (pull_request) Successful in 2h0m46s
e555379897
All checks were successful
clang-format / check-format (push) Successful in 1m3s
Required
Details
clang-format / check-format (pull_request) Successful in 50s
Required
Details
markdownlint / markdown-lint (push) Successful in 28s
Required
Details
markdownlint / markdown-lint (pull_request) Successful in 33s
Required
Details
formal / definitions (push) Successful in 2m14s
Required
Details
formal / definitions (pull_request) Successful in 2m9s
Required
Details
ci / smoke (push) Successful in 39m11s
Required
Details
ci / smoke (pull_request) Successful in 38m7s
Required
Details
ci / sanitizers (push) Successful in 2h5m18s
Required
Details
ci / sanitizers (pull_request) Successful in 2h0m46s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'phase2/p2-14-e-decision-ledgers:phase2/p2-14-e-decision-ledgers'
git switch 'phase2/p2-14-e-decision-ledgers'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES!672
No description provided.