Phase 2: Repair local validation hooks (#605) #606
No reviewers
Labels
No labels
bug
cli
core
docs
event
experiment
figure
invariant
metrics
oracle
phase-0
phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
provenance
revocation
tests
workload
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erikinkinen/AES!606
Loading…
Reference in a new issue
No description provided.
Delete branch "phase2/bug-605-local-hooks"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task
Closes #605
Summary
The local Markdown hook selected Ruby markdownlint with a missing
.markdownlint.yaml, while CI used the Node.js CLI and.markdownlint.json. Development setup also relied on a system/user Python install, leaving the installed hook unable to importpre_commiton this checkout.Install both hook types from an ignored
.venv-devenvironment. Pin pre-commit 4.7.0 and use markdownlint-cli 0.45.0 with the existing JSON configuration in both hooks and CI. Document setup and explicit push-stage validation.Scope
Development setup, Markdown hook/CI parity, and usage documentation. No simulator semantics or research protocol changes.
Design intent
The generated hook points to the isolated interpreter, so activation and system Python packages are unnecessary. Preserve all existing hygiene and C++ formatting checks.
Phase discipline
Tooling defect found while implementing P2-01 (#84); Phase 2 milestone. This PR is dedicated to issue #605.
Verification
bash tools/dev-setup.sh: passed in a separate checkout of the baseline plus this fix..venv-dev/bin/pre-commit run --all-files: all eight hooks passed..venv-dev/bin/pre-commit run --all-files --hook-stage pre-push: all eight hooks passed.git verify-commit HEADverified the signed commit.