Phase 2: Make Rights header self-contained (#610) #611

Merged
erikinkinen merged 1 commit from phase2/bug-610-rights-header into main 2026-10-20 15:59:55 +02:00
Owner

Task

Closes #610

Summary

Including aes/core/rights.hpp first failed because its C++20 spaceship operator requires <compare>, which the public header did not include. Add the direct standard-library dependency so the header no longer relies on consumer include order.

Scope

One include in core/include/aes/core/rights.hpp; Rights representation and operators are unchanged.

Design intent

Make the public header self-contained. Preserve the original Phase 1 source for baseline capture; the external fixture producer explicitly supplies <compare> when compiling against that older revision.

Phase discipline

Defect discovered during P2-02 (#85), independently fixed and reviewed here.

Verification

  • Standalone translation unit with this header first and a constexpr ordering assertion: fails on the frozen baseline and passes with this change.
  • Exact compiler commands, input and observed results.
  • Formatting and actual commit/push hooks passed; commit signature verified.
  • Existing build and tests must pass in all required Forgejo checks before merge.
# Task Closes #610 ## Summary Including `aes/core/rights.hpp` first failed because its C++20 spaceship operator requires `<compare>`, which the public header did not include. Add the direct standard-library dependency so the header no longer relies on consumer include order. ## Scope One include in `core/include/aes/core/rights.hpp`; Rights representation and operators are unchanged. ## Design intent Make the public header self-contained. Preserve the original Phase 1 source for baseline capture; the external fixture producer explicitly supplies `<compare>` when compiling against that older revision. ## Phase discipline Defect discovered during P2-02 (#85), independently fixed and reviewed here. ## Verification - Standalone translation unit with this header first and a constexpr ordering assertion: fails on the frozen baseline and passes with this change. - [Exact compiler commands, input and observed results](https://git.erikinkinen.fi/attachments/5fa834a7-667e-4c40-b356-f9a1a5591e93). - Formatting and actual commit/push hooks passed; commit signature verified. - Existing build and tests must pass in all required Forgejo checks before merge.
erikinkinen added this to the Phase 2 milestone 2026-10-20 15:53:32 +02:00
Phase 2: Make Rights header self-contained (#610)
All checks were successful
markdownlint / markdown-lint (pull_request) Successful in 18s
clang-format / check-format (pull_request) Successful in 19s
ci / smoke (pull_request) Successful in 2m19s
clang-format / check-format (push) Successful in 15s
markdownlint / markdown-lint (push) Successful in 15s
ci / smoke (push) Successful in 2m11s
8660c0113f
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES!611
No description provided.