[BUG] Exclude final-sector padding from FAT fixed-root directories #5
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/fatd#5
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The FAT12/FAT16 fixed-root scanner treats final-sector padding as directory slots. A declared root-entry count that does not fill its last sector can therefore expose a phantom filename from bytes outside the logical directory. This is a source-derived correctness finding; no runtime reproduction has been executed.
Reproduction
Use a fixed-root geometry with 17 declared 32-byte entries and 512-byte sectors, hence two root sectors. Mark the 17 logical entries deleted and place a syntactically valid short entry named GHOST.TXT in physical slot 17 (the first padding slot). At the revision below, scan_records iterates both complete sectors and scan_sector_records visits every 32-byte chunk. The extra entry is eligible for lookup or enumeration despite lying outside the declared directory. The added independent fixture authors this exact geometry; it is unrun under the current testing waiver.
Expected and actual behavior
Expected: scan only the declared 17 entries; final-sector padding never supplies a name. A continuation at slot 17 is EOF. Actual source behavior: sector-rounded scanning can return the padding entry. The shared scanner must cap the final slice using the declared entry count, for both legacy operations and native position-based observation.
Environment and identity
148e8d86, original scanner.Evidence and prior checks
The media geometry rounds root entries to sectors, while the original scanner passes each complete sector to the entry parser. The source repair bounds only the final logical slice and preserves actual block-transfer width. A literal deleted-slot/padding fixture is authored, along with a continuation control. Tests, builds, lint checks, VM/profiler execution and CI observation remain deferred. No pass or executed reproduction is claimed.
Tracking
Resolved in fatd
a5481166within the coherent signed directory dependency closure. Appropriate regression controls are authored and unrun. Source repair and publication are complete; testing and CI execution remain waived, with no executed reproduction or pass claimed.Related source-qualified status and directory feature, Fatd review and Phase 6 master. The source repair and coherent immutable revisions are signed and published; testing remains waived and no executed reproduction is claimed.
erikinkinen referenced this issue from erix/posixd2026-09-30 15:38:46 +02:00
erikinkinen referenced this issue from erix/blockd2026-09-30 15:38:57 +02:00
erikinkinen referenced this issue from erix/coreutils2026-09-30 15:39:00 +02:00
erikinkinen referenced this issue from erix/crashd2026-09-30 15:39:05 +02:00
erikinkinen referenced this issue from erix/deviced2026-09-30 15:39:08 +02:00
erikinkinen referenced this issue from erix/docs2026-09-30 15:39:10 +02:00
erikinkinen referenced this issue from erix/drv-acpi2026-09-30 15:39:13 +02:00
erikinkinen referenced this issue from erix/drv-i80422026-09-30 15:39:17 +02:00
erikinkinen referenced this issue from erix/drv-ps2-keyboard2026-09-30 15:39:21 +02:00
erikinkinen referenced this issue from erix/drv-ps2-mouse2026-09-30 15:39:23 +02:00
erikinkinen referenced this issue from erix/drv-rtc-cmos2026-09-30 15:39:32 +02:00
erikinkinen referenced this issue from erix/drv-serial2026-09-30 15:39:36 +02:00
erikinkinen referenced this issue from erix/drv-virtio-block2026-09-30 15:39:42 +02:00
erikinkinen referenced this issue from erix/dynlinkd2026-09-30 15:39:43 +02:00
erikinkinen referenced this issue from erix/e2fsd2026-09-30 15:39:45 +02:00
erikinkinen referenced this issue from erix/exsh2026-09-30 15:39:47 +02:00
erikinkinen referenced this issue from erix/extop2026-09-30 15:39:50 +02:00
erikinkinen referenced this issue2026-09-30 15:39:53 +02:00
erikinkinen referenced this issue from erix/fbcond2026-09-30 15:39:56 +02:00
erikinkinen referenced this issue from erix/hotplugd2026-09-30 15:39:58 +02:00
erikinkinen referenced this issue from erix/inputd2026-09-30 15:40:00 +02:00
erikinkinen referenced this issue from erix/integration2026-09-30 15:40:04 +02:00
erikinkinen referenced this issue from erix/irqd2026-09-30 15:40:07 +02:00
erikinkinen referenced this issue from erix/kernel2026-09-30 15:40:12 +02:00
erikinkinen referenced this issue from erix/keyd2026-09-30 15:40:16 +02:00
erikinkinen referenced this issue from erix/launchd2026-09-30 15:40:19 +02:00
erikinkinen referenced this issue from erix/lib-block2026-09-30 15:40:22 +02:00
erikinkinen referenced this issue from erix/lib-bootstrap2026-09-30 15:40:24 +02:00
erikinkinen referenced this issue from erix/lib-capabi2026-09-30 15:40:25 +02:00
erikinkinen referenced this issue from erix/lib-driver2026-09-30 15:40:28 +02:00
erikinkinen referenced this issue from erix/lib-input2026-09-30 15:40:29 +02:00
erikinkinen referenced this issue from erix/lib-interrupt2026-09-30 15:40:30 +02:00
erikinkinen referenced this issue from erix/lib-ipc2026-09-30 15:40:32 +02:00
erikinkinen referenced this issue from erix/lib-log2026-09-30 15:40:33 +02:00
erikinkinen referenced this issue from erix/lib-posixabi2026-09-30 15:40:34 +02:00
erikinkinen referenced this issue from erix/lib-service2026-09-30 15:40:35 +02:00
erikinkinen referenced this issue from erix/lib-stdio2026-09-30 15:40:35 +02:00
erikinkinen referenced this issue from erix/lib-time2026-09-30 15:40:35 +02:00
erikinkinen referenced this issue from erix/lib-tty2026-09-30 15:40:36 +02:00
erikinkinen referenced this issue from erix/lib-vfs2026-09-30 15:40:37 +02:00
erikinkinen referenced this issue from erix/loaderd2026-09-30 15:40:37 +02:00
erikinkinen referenced this issue from erix/logd2026-09-30 15:40:38 +02:00
erikinkinen referenced this issue from erix/memd2026-09-30 15:40:38 +02:00
erikinkinen referenced this issue from erix/named2026-09-30 15:40:39 +02:00
erikinkinen referenced this issue from erix/pagerd2026-09-30 15:40:40 +02:00
erikinkinen referenced this issue from erix/posixd2026-09-30 15:40:40 +02:00
erikinkinen referenced this issue from erix/powerboxd2026-09-30 15:40:41 +02:00
erikinkinen referenced this issue from erix/probed2026-09-30 15:40:41 +02:00
erikinkinen referenced this issue from erix/procd2026-09-30 15:40:42 +02:00
erikinkinen referenced this issue from erix/ramfsd2026-09-30 15:40:42 +02:00
erikinkinen referenced this issue from erix/rootd2026-09-30 15:40:42 +02:00
erikinkinen referenced this issue from erix/seriald2026-09-30 15:40:42 +02:00
erikinkinen referenced this issue from erix/timed2026-09-30 15:40:43 +02:00
erikinkinen referenced this issue from erix/ttyd2026-09-30 15:40:43 +02:00
erikinkinen referenced this issue from erix/vfsd2026-09-30 15:40:44 +02:00
erikinkinen referenced this issue from erix/vspaced2026-09-30 15:40:44 +02:00