WIP: Drain retained image jobs after failure #566

Draft
erikinkinen wants to merge 1 commit from feature/retained-image-failed-queue into feature/retained-native-companion-source
Owner

After observing a failed retained image job, drain every already launched producer under its existing wait and retirement duties, then refuse further queue dispatch. Previously the queue continued starting later roles until the final collection step. Legacy dispatch behavior is unchanged.

Depends on #565. Three real child-job controls cover failure draining, successful dispatch and the existing legacy behavior; independent syntax and AST checks pass.

  • Drain existing jobs and stop new retained production after an observed failure.
  • Pass actual child-job and syntax controls.
  • Complete fresh image and guest acceptance with the remaining producer limits intact.
After observing a failed retained image job, drain every already launched producer under its existing wait and retirement duties, then refuse further queue dispatch. Previously the queue continued starting later roles until the final collection step. Legacy dispatch behavior is unchanged. Depends on [#565](https://git.erikinkinen.fi/erix/integration/pulls/565). Three real child-job controls cover failure draining, successful dispatch and the existing legacy behavior; independent syntax and AST checks pass. - [x] Drain existing jobs and stop new retained production after an observed failure. - [x] Pass actual child-job and syntax controls. - [ ] Complete fresh image and guest acceptance with the remaining producer limits intact.
erikinkinen added this to the Alpha 1 milestone 2026-11-08 02:18:08 +01:00
fix: Drain retained producers after an observed image failure
Some checks failed
CI / rust (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Failing after 11s
CI / rust (push) Failing after 2m2s
Coreutils provider graph / coreutils (push) Successful in 3m55s
CI / host_one (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_three (push) Has been skipped
CI / host_two (push) Has been skipped
CI / integration (push) Has been skipped
41bcb3de51
Wait every already launched producer under its existing retirement duty and refuse subsequent queued production after a failed retained image job. Preserve legacy dispatch behavior.
Author
Owner

Prepared the failed-queue feature at 51d5cd03, on #565’s prepared history.

The retained queue now checks sticky failure before starting a child. Previously, a caller that handled an earlier refusal could still start another producer before the post-start check. Already launched jobs retain their original waits, and legacy dispatch behavior is unchanged.

The original branch remains intact. The candidate needs fresh CI and review after its prepared prerequisite is reconciled.

Prepared the failed-queue feature at [51d5cd03](https://git.erikinkinen.fi/erix/integration/commit/51d5cd03aff2a65f0c9e6db860c000978001ebf0), on #565’s prepared history. The retained queue now checks sticky failure before starting a child. Previously, a caller that handled an earlier refusal could still start another producer before the post-start check. Already launched jobs retain their original waits, and legacy dispatch behavior is unchanged. The original branch remains intact. The candidate needs fresh CI and review after its prepared prerequisite is reconciled.
Author
Owner

Prepared 8c4c37ba2b94c4594f2aadd26c3956a4142fd213 on feature/retained-image-failed-queue-merge-ready-8c4c37ba now includes the canonical helper, fixture and Rust archive fixes from #564. The feature remains separate, and the original source and previous prepared ref are preserved. Review should use this new commit.

Prepared `8c4c37ba2b94c4594f2aadd26c3956a4142fd213` on `feature/retained-image-failed-queue-merge-ready-8c4c37ba` now includes the canonical helper, fixture and Rust archive fixes from #564. The feature remains separate, and the original source and previous prepared ref are preserved. Review should use this new commit.
Some checks failed
CI / rust (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Failing after 11s
CI / rust (push) Failing after 2m2s
Coreutils provider graph / coreutils (push) Successful in 3m55s
CI / host_one (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_three (push) Has been skipped
CI / host_two (push) Has been skipped
CI / integration (push) Has been skipped
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'feature/retained-image-failed-queue:feature/retained-image-failed-queue'
git switch 'feature/retained-image-failed-queue'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'feature/retained-native-companion-source'
git merge --no-ff 'feature/retained-image-failed-queue'
git switch 'feature/retained-image-failed-queue'
git rebase 'feature/retained-native-companion-source'
git switch 'feature/retained-native-companion-source'
git merge --ff-only 'feature/retained-image-failed-queue'
git switch 'feature/retained-image-failed-queue'
git rebase 'feature/retained-native-companion-source'
git switch 'feature/retained-native-companion-source'
git merge --no-ff 'feature/retained-image-failed-queue'
git switch 'feature/retained-native-companion-source'
git merge --squash 'feature/retained-image-failed-queue'
git switch 'feature/retained-native-companion-source'
git merge --ff-only 'feature/retained-image-failed-queue'
git switch 'feature/retained-native-companion-source'
git merge 'feature/retained-image-failed-queue'
git push origin 'feature/retained-native-companion-source'
Sign in to join this conversation.
No description provided.