fix: Order native fixture retirement after observed cleanup #661

Open
erikinkinen wants to merge 0 commits from fix/native-fixture-retirement-order into feature/owned-native-build-pipeline
Owner

Summary and rationale

Make the native-wrapper retirement regression causal: the negative fixture holds its actual input owner until the copied runner has selected the existing missing-result cleanup branch. The observation marker changes no predicate, cancellation, wait or receipt result. The positive delays only its first physical probe, leaving the second serial owner to retire normally.

Tracking and scope

Repair the fixture exercised by #628 and #659. Only the maintained diagnostic test changes; this is not a production runner defect or guest result.

Architecture, authority and failure behavior

The copied entry always invokes original native finish in finally and retains raw primary and independent cleanup errors. The marker is descriptive fixture data, never a source/native owner or accepted result. All original eight-second ends, native owners, production code, private-output assertions, timeout and foreign-receipt checks remain unchanged.

Validation evidence

The actual causal positive/negative case and full 31 diagnostic controls pass under the original 120/15-second caller; five syntax controls pass. The complete 407-module helper closure checks twice unchanged. Production runners, seven native-owner bodies and bootstrap are byte-identical to the base. Rust/Clippy and image/guest execution are inapplicable to this test-only change.

Review checklist

  • Signed isolated change with original ownership and limits preserved
  • Meaningful positive, timeout, foreign-input and cleanup controls
  • Natural complete CI regression result
## Summary and rationale Make the native-wrapper retirement regression causal: the negative fixture holds its actual input owner until the copied runner has selected the existing missing-result cleanup branch. The observation marker changes no predicate, cancellation, wait or receipt result. The positive delays only its first physical probe, leaving the second serial owner to retire normally. ## Tracking and scope Repair the fixture exercised by #628 and #659. Only the maintained diagnostic test changes; this is not a production runner defect or guest result. ## Architecture, authority and failure behavior The copied entry always invokes original native finish in finally and retains raw primary and independent cleanup errors. The marker is descriptive fixture data, never a source/native owner or accepted result. All original eight-second ends, native owners, production code, private-output assertions, timeout and foreign-receipt checks remain unchanged. ## Validation evidence The actual causal positive/negative case and full 31 diagnostic controls pass under the original 120/15-second caller; five syntax controls pass. The complete 407-module helper closure checks twice unchanged. Production runners, seven native-owner bodies and bootstrap are byte-identical to the base. Rust/Clippy and image/guest execution are inapplicable to this test-only change. ## Review checklist - [x] Signed isolated change with original ownership and limits preserved - [x] Meaningful positive, timeout, foreign-input and cleanup controls - [ ] Natural complete CI regression result
fix: Order native fixture retirement after observed cleanup
Some checks failed
Markdown / markdown (push) Successful in 28s
Coreutils provider graph / coreutils (push) Failing after 1m45s
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
CI / cargo_publications (push) Successful in 4m10s
CI / rust (push) Failing after 11m20s
CI / native_sources (push) Has been skipped
CI / host_three (push) Has been skipped
CI / host_one (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / integration (push) Has been skipped
bffeb91b4a
Replace the unsynchronized negative sleep with a marker emitted only after the copied runner selects its actual missing-result cleanup branch. Retain the same owner through original finish, preserve raw errors, delay only the first positive probe, and keep all original production clocks and assertions unchanged.
erikinkinen added this to the Alpha 1 milestone 2026-11-10 08:37:49 +01:00
Some checks failed
Markdown / markdown (push) Successful in 28s
Coreutils provider graph / coreutils (push) Failing after 1m45s
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
CI / cargo_publications (push) Successful in 4m10s
CI / rust (push) Failing after 11m20s
CI / native_sources (push) Has been skipped
CI / host_three (push) Has been skipped
CI / host_one (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / integration (push) Has been skipped
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'fix/native-fixture-retirement-order:fix/native-fixture-retirement-order'
git switch 'fix/native-fixture-retirement-order'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'feature/owned-native-build-pipeline'
git merge --no-ff 'fix/native-fixture-retirement-order'
git switch 'fix/native-fixture-retirement-order'
git rebase 'feature/owned-native-build-pipeline'
git switch 'feature/owned-native-build-pipeline'
git merge --ff-only 'fix/native-fixture-retirement-order'
git switch 'fix/native-fixture-retirement-order'
git rebase 'feature/owned-native-build-pipeline'
git switch 'feature/owned-native-build-pipeline'
git merge --no-ff 'fix/native-fixture-retirement-order'
git switch 'feature/owned-native-build-pipeline'
git merge --squash 'fix/native-fixture-retirement-order'
git switch 'feature/owned-native-build-pipeline'
git merge --ff-only 'fix/native-fixture-retirement-order'
git switch 'feature/owned-native-build-pipeline'
git merge 'fix/native-fixture-retirement-order'
git push origin 'feature/owned-native-build-pipeline'
Sign in to join this conversation.
No description provided.