WIP: Avoid repeating retained-space forest verification #664

Draft
erikinkinen wants to merge 0 commits from perf/offline-retained-space-checks into feature/source-input-offline-execution
Owner

Retained-space accounting walked the same admitted forest twice before measuring its descriptors. Use the defining forest counter’s complete check once, keeping the inventory, catalog, descriptor and ancestor checks and the original failure behavior.

Refs #652; depends on #662.

  • Remove the adjacent duplicate forest walk without retaining approval between operations.
  • Exercise genuine source export/admission, positive retirement, namespace-change refusal and sticky failure after restoration.
  • Update the complete helper declaration and original caller binding; native ownership helpers remain unchanged.
  • Complete CI on this revision.

The focused caller passes on 520486f8 with positive process and forest cleanup. No whole-build speedup or full native/guest acceptance is claimed.

Retained-space accounting walked the same admitted forest twice before measuring its descriptors. Use the defining forest counter’s complete check once, keeping the inventory, catalog, descriptor and ancestor checks and the original failure behavior. Refs #652; depends on #662. - [x] Remove the adjacent duplicate forest walk without retaining approval between operations. - [x] Exercise genuine source export/admission, positive retirement, namespace-change refusal and sticky failure after restoration. - [x] Update the complete helper declaration and original caller binding; native ownership helpers remain unchanged. - [ ] Complete CI on this revision. The focused caller passes on `520486f8` with positive process and forest cleanup. No whole-build speedup or full native/guest acceptance is claimed.
erikinkinen added this to the Alpha 1 milestone 2026-11-10 09:46:27 +01:00
Let the defining retained-space counter perform its complete original forest proof immediately before measurement. Keep inventory and catalog verification, original descriptor checks and sticky failures while removing the adjacent duplicate walk.
Bind the complete helper graph to the signed code revision containing original retained-space accounting.
Select the complete declared helper cohort in all original input callers without altering their native ownership interface.
test: Distinguish failed source withdrawal from retirement
Some checks failed
Markdown / markdown (push) Successful in 23s
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
CI / rust (push) Failing after 4m48s
CI / native_sources (push) Has been skipped
CI / cargo_publications (push) Failing after 4m55s
CI / host_three (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_one (push) Has been skipped
CI / integration (push) Has been skipped
Coreutils provider graph / coreutils (push) Successful in 6m12s
520486f8ad
Keep the original namespace failure sticky through close and require uncertain source withdrawal to remain incomplete. Exercise an independent unchanged forest to prove ordinary positive retirement.
Author
Owner

On a fresh admitted single-library fixture, retained-space measurement performs one forest proof and three namespace walks, compared with two proofs and six walks before this change. This measures repeated verification work in that operation; whole-build performance remains open.

On a fresh admitted single-library fixture, retained-space measurement performs one forest proof and three namespace walks, compared with two proofs and six walks before this change. This measures repeated verification work in that operation; whole-build performance remains open.
Some checks failed
Markdown / markdown (push) Successful in 23s
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
CI / rust (push) Failing after 4m48s
CI / native_sources (push) Has been skipped
CI / cargo_publications (push) Failing after 4m55s
CI / host_three (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_one (push) Has been skipped
CI / integration (push) Has been skipped
Coreutils provider graph / coreutils (push) Successful in 6m12s
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'perf/offline-retained-space-checks:perf/offline-retained-space-checks'
git switch 'perf/offline-retained-space-checks'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'feature/source-input-offline-execution'
git merge --no-ff 'perf/offline-retained-space-checks'
git switch 'perf/offline-retained-space-checks'
git rebase 'feature/source-input-offline-execution'
git switch 'feature/source-input-offline-execution'
git merge --ff-only 'perf/offline-retained-space-checks'
git switch 'perf/offline-retained-space-checks'
git rebase 'feature/source-input-offline-execution'
git switch 'feature/source-input-offline-execution'
git merge --no-ff 'perf/offline-retained-space-checks'
git switch 'feature/source-input-offline-execution'
git merge --squash 'perf/offline-retained-space-checks'
git switch 'feature/source-input-offline-execution'
git merge --ff-only 'perf/offline-retained-space-checks'
git switch 'feature/source-input-offline-execution'
git merge 'perf/offline-retained-space-checks'
git push origin 'feature/source-input-offline-execution'
Sign in to join this conversation.
No description provided.