WIP: perf: Avoid a repeated source read during unit lookup #732

Draft
erikinkinen wants to merge 1 commit from perf/unit-query-binding-projection into feature/native-scripted-root-build
Owner

Unit lookup already finishes full source PRE and POST around its Cargo query. Resolve the original package binding from that same typed completion instead of repeating the complete source read. Exact node, scope, profile, unit roster, completion and pipeline checks surround the lookup. Later uses still perform their own full proofs.

Depends on #690.

  • Resolve the original binding within the fixed query operation.
  • Add checks for complete source PRE/POST, replaced completion and copied views.
  • Demonstrate the changed lookup with actual source owners.
  • Exercise the change through native dependency compilation.
Unit lookup already finishes full source PRE and POST around its Cargo query. Resolve the original package binding from that same typed completion instead of repeating the complete source read. Exact node, scope, profile, unit roster, completion and pipeline checks surround the lookup. Later uses still perform their own full proofs. Depends on [#690](https://git.erikinkinen.fi/erix/integration/pulls/690). - [x] Resolve the original binding within the fixed query operation. - [x] Add checks for complete source PRE/POST, replaced completion and copied views. - [x] Demonstrate the changed lookup with actual source owners. - [ ] Exercise the change through native dependency compilation.
erikinkinen added this to the Alpha 1 milestone 2026-11-11 16:43:54 +01:00
Select original typed package bindings on the same checked query stack instead of repeating the complete source body proof a third time. Keep full source PRE and POST and reject replaced node, completion, pipeline or unit occupations.
Record the complete original import closure after the fixed unit query binding change.
build: Bind the unit query projection declaration
Some checks failed
Markdown / markdown (push) Successful in 31s
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Coreutils provider graph / coreutils (push) Successful in 6m32s
CI / rust (push) Failing after 7m38s
CI / cargo_publications (push) Failing after 7m43s
CI / native_sources (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_three (push) Has been skipped
CI / host_one (push) Has been skipped
CI / host_two (push) Has been skipped
CI / integration (push) Has been skipped
657bdb5c78
Select the exact implementation and complete source declaration for the original input runner.
ci: Select external storage for input diagnostics
Some checks failed
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Successful in 33s
Coreutils provider graph / coreutils (push) Failing after 3m29s
CI / rust (push) Failing after 10m33s
CI / cargo_publications (push) Failing after 11m53s
CI / native_sources (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_one (push) Has been skipped
CI / host_three (push) Has been skipped
CI / integration (push) Has been skipped
77901a737a
Provide the runner temporary directory to the owned-input diagnostic step so its retained fixture data stays outside the source checkout.

(cherry picked from commit 4581a707a3)
Some checks failed
CI / cargo_publications (pull_request) Has been skipped
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Successful in 33s
Coreutils provider graph / coreutils (push) Failing after 3m29s
CI / rust (push) Failing after 10m33s
CI / cargo_publications (push) Failing after 11m53s
CI / native_sources (push) Has been skipped
CI / host_zero (push) Has been skipped
CI / host_two (push) Has been skipped
CI / host_one (push) Has been skipped
CI / host_three (push) Has been skipped
CI / integration (push) Has been skipped
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'perf/unit-query-binding-projection:perf/unit-query-binding-projection'
git switch 'perf/unit-query-binding-projection'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'feature/native-scripted-root-build'
git merge --no-ff 'perf/unit-query-binding-projection'
git switch 'perf/unit-query-binding-projection'
git rebase 'feature/native-scripted-root-build'
git switch 'feature/native-scripted-root-build'
git merge --ff-only 'perf/unit-query-binding-projection'
git switch 'perf/unit-query-binding-projection'
git rebase 'feature/native-scripted-root-build'
git switch 'feature/native-scripted-root-build'
git merge --no-ff 'perf/unit-query-binding-projection'
git switch 'feature/native-scripted-root-build'
git merge --squash 'perf/unit-query-binding-projection'
git switch 'feature/native-scripted-root-build'
git merge --ff-only 'perf/unit-query-binding-projection'
git switch 'feature/native-scripted-root-build'
git merge 'perf/unit-query-binding-projection'
git push origin 'feature/native-scripted-root-build'
Sign in to join this conversation.
No description provided.