WIP: Bind screenshot identity to acquired bytes #793

Draft
erikinkinen wants to merge 1 commit from fix/trusted-frame-snapshot-identity into feature/native-input-owner-cohort
Owner

Read each trusted screenshot through one bounded regular-file descriptor. PPM decoding and freshness hashing then use the same retained bytes. Reject changes during acquisition and preserve descriptor-cleanup failures.

Keep the strict PPM grammar, existing pathname API and 32 MiB bound. The console-input documentation describes the snapshot contract. Based on #564.

  • Bind decoded review and digest to one original byte snapshot.
  • Cover replacement, removal, growth, special files and cleanup failure.
  • Retain existing framebuffer, prompt and socket-fixture behavior.
  • Complete final-head CI and dependency integration.
Read each trusted screenshot through one bounded regular-file descriptor. PPM decoding and freshness hashing then use the same retained bytes. Reject changes during acquisition and preserve descriptor-cleanup failures. Keep the strict PPM grammar, existing pathname API and 32 MiB bound. The console-input documentation describes the snapshot contract. Based on [#564](https://git.erikinkinen.fi/erix/integration/pulls/564). - [x] Bind decoded review and digest to one original byte snapshot. - [x] Cover replacement, removal, growth, special files and cleanup failure. - [x] Retain existing framebuffer, prompt and socket-fixture behavior. - [ ] Complete final-head CI and dependency integration.
erikinkinen added this to the Alpha 1 milestone 2026-11-15 14:43:12 +01:00
fix: Bind trusted screenshot hashes to acquired bytes
Some checks failed
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Successful in 4s
Coreutils provider graph / coreutils (push) Successful in 1m34s
CI / rust (push) Successful in 2m25s
CI / native_sources (push) Successful in 8s
CI / host_one (push) Successful in 8m6s
CI / host_zero (push) Successful in 8m20s
CI / host_two (push) Successful in 9m10s
CI / host_three (push) Successful in 10m52s
CI / integration (push) Failing after 10m0s
a3bf3f771c
Acquire each screenshot through one bounded regular-file descriptor and retain immutable bytes for PPM decoding and freshness hashing. Reject concurrent changes and preserve cleanup failures so a replaced pathname cannot mix rendered review and digest identity.
Some checks failed
CI / rust (pull_request) Has been skipped
CI / native_sources (pull_request) Has been skipped
CI / host_zero (pull_request) Has been skipped
CI / host_one (pull_request) Has been skipped
CI / host_two (pull_request) Has been skipped
CI / host_three (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
Coreutils provider graph / coreutils (pull_request) Has been skipped
Markdown / markdown (pull_request) Has been skipped
Markdown / markdown (push) Successful in 4s
Coreutils provider graph / coreutils (push) Successful in 1m34s
CI / rust (push) Successful in 2m25s
CI / native_sources (push) Successful in 8s
CI / host_one (push) Successful in 8m6s
CI / host_zero (push) Successful in 8m20s
CI / host_two (push) Successful in 9m10s
CI / host_three (push) Successful in 10m52s
CI / integration (push) Failing after 10m0s
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'fix/trusted-frame-snapshot-identity:fix/trusted-frame-snapshot-identity'
git switch 'fix/trusted-frame-snapshot-identity'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'feature/native-input-owner-cohort'
git merge --no-ff 'fix/trusted-frame-snapshot-identity'
git switch 'fix/trusted-frame-snapshot-identity'
git rebase 'feature/native-input-owner-cohort'
git switch 'feature/native-input-owner-cohort'
git merge --ff-only 'fix/trusted-frame-snapshot-identity'
git switch 'fix/trusted-frame-snapshot-identity'
git rebase 'feature/native-input-owner-cohort'
git switch 'feature/native-input-owner-cohort'
git merge --no-ff 'fix/trusted-frame-snapshot-identity'
git switch 'feature/native-input-owner-cohort'
git merge --squash 'fix/trusted-frame-snapshot-identity'
git switch 'feature/native-input-owner-cohort'
git merge --ff-only 'fix/trusted-frame-snapshot-identity'
git switch 'feature/native-input-owner-cohort'
git merge 'fix/trusted-frame-snapshot-identity'
git push origin 'feature/native-input-owner-cohort'
Sign in to join this conversation.
No description provided.