[BUG] Realm diagnostic fixture fails to compile #23
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/launchd#23
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Two Vfs refusal fixtures return an encoded byte count where their frame callbacks
require unit, stopping Launchd's Rust CI before its unit tests run.
Reproduction
Run the maintained Cargo workspace with
cargo clippy --all-targets --all-features -- -D warnings.The failures appear in CI 410 and 412.
Expected and actual behavior
The callbacks should encode the refusal and return
Result<(), Error>.VfsLaunchObjectResponseV2::encode_intoreturnsResult<usize, Error>instead.Passing it directly to
encode_public_replyorpeer_frame::encode_callfailswith E0308 in
realm_directory_tests_io.rsandtests/realm_filesystem_source.rs.Environment and identity
39d2a7cband27ac401b; LibIPC3f24f57eand9116efed.Evidence and prior checks
CI 410 and
CI 412
report the callback mismatches. Their complete original logs are retained.
The codec's byte count remains useful; the callbacks should check it and return
unit without changing the encoded refusal or hiding errors.
Tracking
Related: realm-directory diagnostics
and the implementation.
27ac401bfixes the fixture callback: it checks the encoded reply length and returns()while preserving codec errors. The remaining checklist items cover the full component checks and CI.6ea5ba13fixes the second callback mismatch revealed by CI 412, and Integration051890a1selects it. CI 414 now passes compilation, strict Clippy and Markdown. One diagnostic control still fails and is being investigated; the remaining checklist items stay open.The callback compilation fix is confirmed in CI 414, and both unchanged fixtures also compile at
3e69090ee4. The later cleanup-order failure is fixed separately and tracked in #24.