[BUG] Realm diagnostic fixture fails to compile #23

Closed
opened 2026-10-17 11:31:40 +02:00 by erikinkinen · 3 comments
Owner

Summary

Two Vfs refusal fixtures return an encoded byte count where their frame callbacks
require unit, stopping Launchd's Rust CI before its unit tests run.

Reproduction

Run the maintained Cargo workspace with
cargo clippy --all-targets --all-features -- -D warnings.
The failures appear in CI 410 and 412.

Expected and actual behavior

The callbacks should encode the refusal and return Result<(), Error>.
VfsLaunchObjectResponseV2::encode_into returns Result<usize, Error> instead.
Passing it directly to encode_public_reply or peer_frame::encode_call fails
with E0308 in realm_directory_tests_io.rs and
tests/realm_filesystem_source.rs.

Environment and identity

  • Launchd 39d2a7cb and 27ac401b; LibIPC 3f24f57e and 9116efed.
  • Linux x86-64, Rust 1.93.1, all targets and features, warnings denied.
  • The failures are in test fixtures; no guest operation is reached.

Evidence and prior checks

CI 410 and
CI 412
report the callback mismatches. Their complete original logs are retained.
The codec's byte count remains useful; the callbacks should check it and return
unit without changing the encoded refusal or hiding errors.

Tracking

Related: realm-directory diagnostics
and the implementation.

  • Adapt both fixture callbacks without changing the encoded refusals.
  • Complete strict Clippy and the directory diagnostic controls.
  • Confirm the corrected source in CI.
## Summary Two Vfs refusal fixtures return an encoded byte count where their frame callbacks require unit, stopping Launchd's Rust CI before its unit tests run. ## Reproduction Run the maintained Cargo workspace with `cargo clippy --all-targets --all-features -- -D warnings`. The failures appear in CI 410 and 412. ## Expected and actual behavior The callbacks should encode the refusal and return `Result<(), Error>`. `VfsLaunchObjectResponseV2::encode_into` returns `Result<usize, Error>` instead. Passing it directly to `encode_public_reply` or `peer_frame::encode_call` fails with E0308 in `realm_directory_tests_io.rs` and `tests/realm_filesystem_source.rs`. ## Environment and identity - Launchd `39d2a7cb` and `27ac401b`; LibIPC `3f24f57e` and `9116efed`. - Linux x86-64, Rust 1.93.1, all targets and features, warnings denied. - The failures are in test fixtures; no guest operation is reached. ## Evidence and prior checks [CI 410](https://git.erikinkinen.fi/erix/launchd/actions/runs/410) and [CI 412](https://git.erikinkinen.fi/erix/launchd/actions/runs/412) report the callback mismatches. Their complete original logs are retained. The codec's byte count remains useful; the callbacks should check it and return unit without changing the encoded refusal or hiding errors. ## Tracking Related: [realm-directory diagnostics](https://git.erikinkinen.fi/erix/launchd/issues/22) and [the implementation](https://git.erikinkinen.fi/erix/launchd/pulls/2). - [x] Adapt both fixture callbacks without changing the encoded refusals. - [x] Complete strict Clippy and the directory diagnostic controls. - [x] Confirm the corrected source in CI.
Author
Owner

27ac401b fixes the fixture callback: it checks the encoded reply length and returns () while preserving codec errors. The remaining checklist items cover the full component checks and CI.

`27ac401b` fixes the fixture callback: it checks the encoded reply length and returns `()` while preserving codec errors. The remaining checklist items cover the full component checks and CI.
Author
Owner

6ea5ba13 fixes the second callback mismatch revealed by CI 412, and Integration 051890a1 selects it. CI 414 now passes compilation, strict Clippy and Markdown. One diagnostic control still fails and is being investigated; the remaining checklist items stay open.

`6ea5ba13` fixes the second callback mismatch revealed by [CI 412](https://git.erikinkinen.fi/erix/launchd/actions/runs/412), and Integration `051890a1` selects it. [CI 414](https://git.erikinkinen.fi/erix/launchd/actions/runs/414) now passes compilation, strict Clippy and Markdown. One diagnostic control still fails and is being investigated; the remaining checklist items stay open.
Author
Owner

The callback compilation fix is confirmed in CI 414, and both unchanged fixtures also compile at 3e69090ee4. The later cleanup-order failure is fixed separately and tracked in #24.

The callback compilation fix is confirmed in CI 414, and both unchanged fixtures also compile at 3e69090ee433a66f10290dea764c219f0f4c3613. The later cleanup-order failure is fixed separately and tracked in #24.
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:34:33 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/launchd#23
No description provided.