[BUG] Failed realm-directory diagnostic replies before cleanup finishes #24
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/launchd#24
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
With realm-directory diagnostics enabled, a failed preparation can reply before
its original cleanup finishes. A pending cleanup failure must keep the original
request held and prevent a diagnostic reply.
Reproduction
At Launchd
6ea5ba13, run the all-feature testcleanup_uncertainty_keeps_original_pending_call_and_emits_nothing.CI 414 reports an extra reply: seven messages where the control expects six.
Expected and actual behavior
A failed admitted diagnostic request should wait until its original realm is
retired. Absence of an immediate result alone does not establish that state;
the original source can still have a pending retirement operation.
The ordinary reply format, successful diagnostic path and caller checks should
retain their existing behavior.
Environment and identity
6ea5ba13, LibIPC9116efed; Linux x86-64, Rust 1.93.1 in CI.launchd-integration-realm-directory-diagnostic.Evidence and prior checks
CI 414 preserves the
original failure. The fix
waits for full retirement, strengthens the cleanup-failure control and covers a
provider that remains busy before retirement. Formatting, strict Clippy,
681 default tests, 687 opt-in tests and all 23 Markdown files pass locally.
Tracking
Related: diagnostic operation
and implementation.
CI 416 passes at
3e69090ee4: the new retirement controls pass in the 687-test suite, with formatting, strict Clippy, Rustdoc, both freestanding checks and all 23 Markdown files clean. This closes the diagnostic retirement regression. The original guest run remains tracked in #22.