WIP: Erase AES key schedules and temporary XTS tweaks #2

Closed
erikinkinen wants to merge 13 commits from feature/posix-compat into main
Owner

Summary and rationale

Erase the AES-256 expanded key schedule when its owner is dropped, and guard the temporary XTS tweak so cleanup runs on every exit. Remove cloning of expanded schedules; the XTS data and tweak keys remain separate owners.

Use the original EriX storage-erasure helpers and document their limits. The branch also updates the component documentation and skips duplicate same-repository pull-request jobs.

Tracking and scope

The linked component audit, implementation and consumer requirements remain part of this WIP review. The phase-wide guest and toolchain build requirements stay with the phase completion issue.

Architecture, authority and failure behavior

Cleanup covers the schedule and temporary storage owned by these values. Callers remain responsible for input keys and prior copies. Volatile erasure does not clear earlier compiler copies, registers, hardware remnants or storage after an abort. The erasure library adds no service, allocator or I/O authority.

The CI guard skips same-repository pull requests before any job steps run. Pushes, fork pull requests and manual runs retain their existing eligibility.

Validation evidence

Formatting, strict Clippy, warning-denied builds and documentation, unit tests, and applicable native/VM and consumer regressions remain required for the declared scope. Authored controls and older successful runs do not establish current full acceptance.

Review checklist

  • Dependencies use immutable revisions, and changes preserve runtime authority.
  • Signed commit uses a tagged title and an explanatory body.
  • Inline comments explain the guard; code files remain below 1,000 lines.
  • Shared template and testing manual document the same CI rule.
  • Shared governance and issue/PR template files remain unchanged.
  • Related issues and phase metadata track the implemented workflow scope.
  • No secrets, private reports or unsupported validation claims are published.

This review remains WIP until its declared scope and dependent requirements are complete.

## Summary and rationale Erase the AES-256 expanded key schedule when its owner is dropped, and guard the temporary XTS tweak so cleanup runs on every exit. Remove cloning of expanded schedules; the XTS data and tweak keys remain separate owners. Use the original EriX storage-erasure helpers and document their limits. The branch also updates the component documentation and skips duplicate same-repository pull-request jobs. ## Tracking and scope - [meta #2](https://git.erikinkinen.fi/erix/meta/issues/2) - [lib-aes #1](https://git.erikinkinen.fi/erix/lib-aes/issues/1) - [integration #65](https://git.erikinkinen.fi/erix/integration/issues/65) - [docs PR #4](https://git.erikinkinen.fi/erix/docs/pulls/4) - [e2fsd PR #3](https://git.erikinkinen.fi/erix/e2fsd/pulls/3) - [integration PR #12](https://git.erikinkinen.fi/erix/integration/pulls/12) - [lib-aes PR #2](https://git.erikinkinen.fi/erix/lib-aes/pulls/2) - [lib-constant-time PR #2](https://git.erikinkinen.fi/erix/lib-constant-time/pulls/2) - [lib-fs-crypto PR #2](https://git.erikinkinen.fi/erix/lib-fs-crypto/pulls/2) - [lib-ipc PR #2](https://git.erikinkinen.fi/erix/lib-ipc/pulls/2) - [lib-sha2 PR #2](https://git.erikinkinen.fi/erix/lib-sha2/pulls/2) The linked component audit, implementation and consumer requirements remain part of this WIP review. The phase-wide guest and toolchain build requirements stay with the phase completion issue. ## Architecture, authority and failure behavior Cleanup covers the schedule and temporary storage owned by these values. Callers remain responsible for input keys and prior copies. Volatile erasure does not clear earlier compiler copies, registers, hardware remnants or storage after an abort. The erasure library adds no service, allocator or I/O authority. The CI guard skips same-repository pull requests before any job steps run. Pushes, fork pull requests and manual runs retain their existing eligibility. ## Validation evidence Formatting, strict Clippy, warning-denied builds and documentation, unit tests, and applicable native/VM and consumer regressions remain required for the declared scope. Authored controls and older successful runs do not establish current full acceptance. ## Review checklist - [x] Dependencies use immutable revisions, and changes preserve runtime authority. - [x] Signed commit uses a tagged title and an explanatory body. - [x] Inline comments explain the guard; code files remain below 1,000 lines. - [x] Shared template and testing manual document the same CI rule. - [x] Shared governance and issue/PR template files remain unchanged. - [x] Related issues and phase metadata track the implemented workflow scope. - [x] No secrets, private reports or unsupported validation claims are published. This review remains WIP until its declared scope and dependent requirements are complete.
ci: Skip duplicate same-repository pull request jobs
All checks were successful
CI / markdown (push) Successful in 9s
CI / test (push) Successful in 27s
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
95daecbf76
Skip pull-request jobs when the head and base repository names match,
since push CI already covers these branches. Retain fork pull-request,
push and manual execution and existing release publication conditions.
Apply the guard before any job steps, including Markdown validation.

Test execution and CI observation are deferred at the user's request;
no execution result is claimed for this workflow-only change.
fix: Retire original AES key schedules
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 5s
CI / test (push) Successful in 18s
658a7ad800
Keep expanded AES schedules as private single owners erased on drop.
Guard original XTS tweak storage and remove schedule cloning. Preserve
existing transformations and document the independent algorithm audit scope.

Tests, builds, lint checks, generated documentation, VM/profiler execution and
CI observation remain deferred. Rustfmt was applied through stdin. No test
pass, warning-free build or measured performance improvement is claimed.
Full EriX guest generations and external Rust/LLVM guest rebuilding remain
required and unperformed.
ci: Adopt the signed original Git dependency helper
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 4s
CI / test (push) Successful in 16s
e87afefb2c
Select the verified immutable Integration helper that preserves actual
Git objects and denies registry dependencies without obsolete path
patches. Retain every duplicate same-repository PR guard. Where needed,
adopt the coherent signed ABI graph and preserve original authority and
validation budgets. Maintain canonical documentation formatting.

Tests and exact-head CI run in parallel with implementation. Earlier failed,
skipped or unrun checks remain distinct from actual passes. Keep the full
EriX guest build generations and external Rust/LLVM guest rebuild required;
no final all-repository CI success or guest completion is claimed.
ci: Adopt the signed original Git dependency helper
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 5s
CI / test (push) Successful in 21s
613f125f80
Select the verified immutable Integration helper that preserves actual
Git objects and denies registry dependencies without obsolete path
patches. Retain every duplicate same-repository PR guard. Where needed,
adopt the coherent signed ABI graph and preserve original authority and
validation budgets. Maintain canonical documentation formatting.

Tests and exact-head CI run in parallel with implementation. Earlier failed,
skipped or unrun checks remain distinct from actual passes. Keep the full
EriX guest build generations and external Rust/LLVM guest rebuild required;
no final all-repository CI success or guest completion is claimed.
erikinkinen changed title from WIP: Skip duplicate same-repository pull request jobs to WIP: Erase AES key schedules and temporary XTS tweaks 2026-10-12 16:01:35 +02:00
build: Align shared library dependency revisions
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 2s
CI / test (push) Successful in 16s
e96f1e475a
Select the current signed library revisions in dependency order.
Keep shared ABI types on one coherent Git graph without changing
capability rights or source identity.
ci: Select the reviewed native process custody helper
Some checks failed
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 6s
CI / test (push) Failing after 12s
722d2802be
Select the coherent Integration source for dependency preparation and
native process ownership. This keeps helper inputs aligned with the
published runtime producer and refuses unsupported descriptor queries
before starting a child.
docs: Remove the superseded testing deferral
Some checks failed
CI / markdown (pull_request) Has been skipped
CI / test (pull_request) Has been skipped
CI / markdown (push) Successful in 3s
CI / test (push) Failing after 7s
67c8eef4df
Remove the outdated execution-waiver instruction from the roadmap so it reflects the active development workflow. Retain the component contract and open conformance, lifecycle and guest requirements.
perf: Use fixed AES field transformations
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 3s
CI / test (push) Successful in 12s
aed2eef2aa
Compute inverse substitution directly through the inverse affine map and
a fixed field-inverse addition chain. Mask coefficient and tweak reductions
and remove the unused exponentiation routine. Preserve the existing modes
and add exhaustive specification checks and an explicit XTS profiler.

This implements the arithmetic design in LibAES #3 and removes the measured
decryption bottleneck in the encrypted filesystem workload.
ci: Adopt the repaired native signal owner
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 9s
CI / test (push) Successful in 37s
2eeb6110f7
Select the coherent Integration helper that admits observed default or
ignored reserved signals while preserving complete native action identity.
Keep the existing workflow commands and limits for Integration #118.
Author
Owner

Published fixed-work AES substitutions and field arithmetic in aed2eef2aa74114323e405a23b99513e723b4661, preserving ciphertext, XTS behavior and key erasure. Matching filesystem consumers and the Integration catalog are updated. Arithmetic design tracks the remaining consumer completion.

Published fixed-work AES substitutions and field arithmetic in `aed2eef2aa74114323e405a23b99513e723b4661`, preserving ciphertext, XTS behavior and key erasure. Matching filesystem consumers and the Integration catalog are updated. [Arithmetic design](https://git.erikinkinen.fi/erix/lib-aes/issues/3) tracks the remaining consumer completion.
docs: Mark fixed-work AES implementation complete
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 2s
CI / test (push) Successful in 9s
d54151c3df
The reviewed arithmetic implementation is now adopted by the filesystem
consumers. Close its roadmap item while retaining the broader audit work.
Author
Owner

Completed the fixed-work AES implementation and filesystem adoption tracked in #3. The roadmap now marks that item complete.

Completed the fixed-work AES implementation and filesystem adoption tracked in [#3](https://git.erikinkinen.fi/erix/lib-aes/issues/3). The roadmap now marks that item complete.
build: Track main dependencies through checked Cargo inputs
Some checks are pending
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 16s
CI / test (push) Has started running
ffb37e0f35
Declare main for internal Git dependencies. Prepare offline Cargo inputs with
the selected Integration helper, then carry the generated workspace, environment
and target directory through each CI step.

Keep shared dependency and review policies aligned.

Refs: erix/integration#142
ci: Select the repaired Cargo gateway
Some checks are pending
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / test (push) Has started running
CI / markdown (push) Has started running
75563bd7e2
Use the shared gateway that selects installed Rust tools when a component
has no toolchain file. Keep tool selection, feature-branch resolution and
original source checks together in the pinned helper snapshot.

Refs: erix/integration#147
ci: Use the shared acquisition fix for packed Git transfers
All checks were successful
CI / markdown (push) Successful in 3s
CI / test (push) Successful in 2m2s
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
46b840c345
Use the shared acquisition fix for packed Git transfers. The pinned helper
keeps unexpected object-store metadata outside the acquired source context.

Refs: erix/integration#150
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:34:34 +01:00
Author
Owner

Replaced by #6, #7. These feature branches preserve the original source in separate changes. Closing this combined PR without merging it; the original branch is retained.

Replaced by [#6](https://git.erikinkinen.fi/erix/lib-aes/pulls/6), [#7](https://git.erikinkinen.fi/erix/lib-aes/pulls/7). These feature branches preserve the original source in separate changes. Closing this combined PR without merging it; the original branch is retained.
erikinkinen closed this pull request 2026-10-30 15:25:21 +01:00
All checks were successful
CI / markdown (push) Successful in 3s
CI / test (push) Successful in 2m2s
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped

Pull request closed

Sign in to join this conversation.
No description provided.