WIP: Simplify CRC updates and strengthen validation #2

Closed
erikinkinen wants to merge 12 commits from feature/posix-compat into main
Owner

Summary and rationale

Replace redundant saturating counters with slice and fixed-range iteration.
Preserve public signatures, polynomials, raw seeds and finalization semantics.
Document empty inputs, chaining, byte order and the checksum/authentication
boundary. The component audit is tracked in issue 1.

Authority and compatibility

The dependency-free no_std library borrows only caller-provided bytes and
returns a scalar checksum. It allocates nothing and acquires or retains no
authority. Every raw seed and valid slice remains accepted. Consumers retain
format validation, authentication and scheduling responsibilities.

Review checklist

  • Formatting, strict Clippy and warning-denied host/freestanding builds.
  • Default/all-feature tests, doctests and private-item rustdoc.
  • Known vectors, arbitrary seeds, all-byte chaining and reflection controls.
  • Complete source audit; authored code stays below 1,000 lines.
  • Coordinated lib-partition and e2fsd checksum regressions.
  • Current component CI; compiler, test and rustdoc stages emit no warnings.
  • Canonical component documents and unchanged shared governance.
  • Manual/API reference covers all eight public routes.
  • Signed commits with explanatory bodies; Cargo manifests remain unchanged.
  • Maintainer review.

Full guest and toolchain builds remain tracked in the
phase completion issue.

## Summary and rationale Replace redundant saturating counters with slice and fixed-range iteration. Preserve public signatures, polynomials, raw seeds and finalization semantics. Document empty inputs, chaining, byte order and the checksum/authentication boundary. The component audit is tracked in [issue 1](https://git.erikinkinen.fi/erix/lib-crc/issues/1). ## Authority and compatibility The dependency-free `no_std` library borrows only caller-provided bytes and returns a scalar checksum. It allocates nothing and acquires or retains no authority. Every raw seed and valid slice remains accepted. Consumers retain format validation, authentication and scheduling responsibilities. ## Review checklist - [x] Formatting, strict Clippy and warning-denied host/freestanding builds. - [x] Default/all-feature tests, doctests and private-item rustdoc. - [x] Known vectors, arbitrary seeds, all-byte chaining and reflection controls. - [x] Complete source audit; authored code stays below 1,000 lines. - [x] Coordinated `lib-partition` and `e2fsd` checksum regressions. - [x] Current component CI; compiler, test and rustdoc stages emit no warnings. - [x] Canonical component documents and unchanged shared governance. - [x] [Manual/API reference](https://git.erikinkinen.fi/erix/docs/pulls/4) covers all eight public routes. - [x] Signed commits with explanatory bodies; Cargo manifests remain unchanged. - [ ] Maintainer review. Full guest and toolchain builds remain tracked in the [phase completion issue](https://git.erikinkinen.fi/erix/integration/issues/65).
refactor: Simplify CRC updates and document raw-state contracts
All checks were successful
CI / markdown (push) Successful in 24s
CI / test (push) Successful in 40s
CI / markdown (pull_request) Successful in 7s
CI / test (pull_request) Successful in 27s
0ee4fe9eb2
Preserve all CRC polynomials, public signatures and seed/finalization semantics while replacing redundant saturating counters with slice and fixed-range iteration. Document raw-state chaining, empty inputs and the pure authority-free call boundary, and replace generic component documentation with the actual checksum contracts.

Add independent seeded-split and reflection regressions, strict rustdoc and freestanding CI gates, exact-commit checkout and predecessor retention. Default/all-feature host tests (8 each), doctests (1 each), strict Clippy, host/freestanding builds, private-item rustdoc, formatting and Markdown checks pass without warnings. Coordinated consumer validation and performance evidence remain separate work.
ci: Preserve original Cargo source identities during setup
All checks were successful
CI / markdown (push) Successful in 13s
CI / markdown (pull_request) Successful in 16s
CI / test (push) Successful in 41s
CI / test (pull_request) Successful in 39s
68f3ffe8d6
Select the published Integration helper that resolves pinned original Git objects through local transport while preserving manifest and lock identities. Existing compiler and dependency policies remain unchanged.

Cold and locked setup, original source verification, formatting, strict Clippy, and all eight tests in default and all-feature configurations pass without warnings.
ci: Skip duplicate same-repository pull request jobs
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 11s
CI / test (push) Successful in 37s
0e7d92f54a
Skip pull-request jobs when the head and base repository names match,
since push CI already covers these branches. Retain fork pull-request,
push and manual execution and existing release publication conditions.
Apply the guard before any job steps, including Markdown validation.

Test execution and CI observation are deferred at the user's request;
no execution result is claimed for this workflow-only change.
ci: Adopt the signed original Git dependency helper
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 4s
CI / test (push) Successful in 23s
af2769cdae
Select the verified immutable Integration helper that preserves actual
Git objects and denies registry dependencies without obsolete path
patches. Retain every duplicate same-repository PR guard. Where needed,
adopt the coherent signed ABI graph and preserve original authority and
validation budgets. Maintain canonical documentation formatting.

Tests and exact-head CI run in parallel with implementation. Earlier failed,
skipped or unrun checks remain distinct from actual passes. Keep the full
EriX guest build generations and external Rust/LLVM guest rebuild required;
no final all-repository CI success or guest completion is claimed.
ci: Adopt the signed original Git dependency helper
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 4s
CI / test (push) Successful in 23s
8dd373510c
Select the verified immutable Integration helper that preserves actual
Git objects and denies registry dependencies without obsolete path
patches. Retain every duplicate same-repository PR guard. Where needed,
adopt the coherent signed ABI graph and preserve original authority and
validation budgets. Maintain canonical documentation formatting.

Tests and exact-head CI run in parallel with implementation. Earlier failed,
skipped or unrun checks remain distinct from actual passes. Keep the full
EriX guest build generations and external Rust/LLVM guest rebuild required;
no final all-repository CI success or guest completion is claimed.
ci: Select the reviewed native process custody helper
Some checks failed
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 4s
CI / test (push) Failing after 11s
8bab86359c
Select the coherent Integration source for dependency preparation and
native process ownership. This keeps helper inputs aligned with the
published runtime producer and refuses unsupported descriptor queries
before starting a child.
docs: Clarify CRC accumulator callers
Some checks failed
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 2s
CI / test (push) Failing after 4s
5d7582e4f2
Name the public rolling-update entry points accurately in the shared accumulator contract. Include private items in warning-denied CI rustdoc and align the component guidance with that coverage.
Author
Owner

The signed checkpoint completes the full public/private inline review. It corrects the shared accumulator's caller description and includes private items in CI rustdoc. Algorithm, API and existing test behavior are unchanged. Wider audit, consumer and timing work remain open.

The [signed checkpoint](https://git.erikinkinen.fi/erix/lib-crc/commit/5d7582e4f2f9bf83359a725781b33b6c27514157) completes the full public/private inline review. It corrects the shared accumulator's caller description and includes private items in CI rustdoc. Algorithm, API and existing test behavior are unchanged. Wider audit, consumer and timing work remain open.
ci: Adopt the repaired native signal owner
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 13s
CI / test (push) Successful in 42s
d8f93eb5fd
Select the coherent Integration helper that admits observed default or
ignored reserved signals while preserving complete native action identity.
Keep the existing workflow commands and limits for Integration #118.
ci: Carry checked Cargo inputs through component jobs
Some checks failed
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 10s
CI / test (push) Failing after 25s
9bb4bcc76b
Prepare Cargo inputs with the selected Integration helper and carry its
workspace, environment and target directory through the existing CI steps.
Keep shared dependency and review policies aligned.

Refs: erix/integration#142
ci: Select the repaired Cargo gateway
Some checks failed
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Failing after 1h1m29s
CI / test (push) Failing after 1h1m33s
6f2fd974d6
Use the shared gateway that selects installed Rust tools when a component
has no toolchain file. Keep tool selection, feature-branch resolution and
original source checks together in the pinned helper snapshot.

Refs: erix/integration#147
ci: Use the shared acquisition fix for packed Git transfers
All checks were successful
CI / test (push) Successful in 54s
CI / markdown (push) Successful in 19s
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
c624e40358
Use the shared acquisition fix for packed Git transfers. The pinned helper
keeps unexpected object-store metadata outside the acquired source context.

Refs: erix/integration#150
docs: Complete the checksum library audit
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 10s
CI / test (push) Successful in 47s
b18e256b9d
Record the pure checksum authority and state review and the coordinated
storage consumer results. Correct stale revision-pin wording to match
Cargo branch selection while preserving exact resolved graph identities.
Author
Owner

The component audit is complete. Updated the review checklist and dependency-policy wording in b18e256b; the checksum implementation and workflow are unchanged. Push run 42 passes. The PR remains draft for maintainer review.

The [component audit](https://git.erikinkinen.fi/erix/lib-crc/issues/1) is complete. Updated the review checklist and dependency-policy wording in [b18e256b](https://git.erikinkinen.fi/erix/lib-crc/commit/b18e256b); the checksum implementation and workflow are unchanged. [Push run 42](https://git.erikinkinen.fi/erix/lib-crc/actions/runs/42) passes. The PR remains draft for maintainer review.
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:34:39 +01:00
Author
Owner

This source is now split into feature PRs, starting at #4 and ending at #6. Each PR links its prerequisite. The complete stack preserves the runtime changes and dependency declarations; obsolete pin checkpoints and documented source-acquisition differences are separated from feature behavior.

Closing this aggregate without merging. The replacement PRs remain WIP for their remaining integration and review.

This source is now split into feature PRs, starting at #4 and ending at #6. Each PR links its prerequisite. The complete stack preserves the runtime changes and dependency declarations; obsolete pin checkpoints and documented source-acquisition differences are separated from feature behavior. Closing this aggregate without merging. The replacement PRs remain WIP for their remaining integration and review.
erikinkinen closed this pull request 2026-10-30 18:22:09 +01:00
All checks were successful
CI / test (pull_request) Has been skipped
CI / markdown (pull_request) Has been skipped
CI / markdown (push) Successful in 10s
CI / test (push) Successful in 47s

Pull request closed

Sign in to join this conversation.
No description provided.