[BUG] Preserve the supported minor in malformed I/O fixtures #4

Closed
opened 2026-09-29 19:08:21 +02:00 by erikinkinen · 0 comments
Owner

Summary

The malformed-I/O test still expects supported compatibility minor 4 to be rejected, then restores obsolete minor 3 before expecting a successful header parse. Both expectations conflict with the published 1.4 codec. This is a source-observed test regression; no test or CI run was performed.

Reproduction

At revision 7ae4eeedb456d8d02057fab387b0e529df8a4c35, inspect VERSION_MINOR_V1 in src/header.rs and exact_minor_and_declared_large_lengths_are_preserved in tests/io_wire_invalid.rs. The codec accepts 4, the rejection list contains 4, and the later successful-header case selects 3.

Expected and actual behavior

Expected: accept the independent supported fixture, reject previous/future minors, then restore that same supported fixture before inspecting declared lengths.

Actual in source: stale expectations invert the supported revision and prevent the length case from reaching its intended assertion. During the coordinated compatibility 1.5 change, update rejected revisions, explicitly establish the initial valid fixture, and restore its original minor bytes instead of another disconnected literal.

Environment and identity

  • LibPosixABI branch feature/posix-compat, starting revision above.
  • Read-only source comparison during dynamic acquisition framing work.
  • No compiler, test, image, VM or CI failure is claimed. Runtime behavior is not changed by this fixture correction.

Evidence and prior checks

Conditional provider acquisition checkpoint: lib-ipc bb5df3d2, lib-posixabi cdc6eb9e, ramfsd ba8ea6da, docs d470ea50, integration b9acf76b, rootd 27835abd.

Compatibility 1.5 now describes Open/openat with raw borrowed pathname bytes and checked independent base, access, lookup, shared-status, inheritance and creation-mode domains. Private provider acquisition/retirement framing retains an original root and acquisition identity before submission. Ramfsd compares actual parent permission evidence and pins no-follow files, directories or symlinks in one exclusive turn. Cleanup does not require the original handle reply; retirement fences delayed replay without tombstone storage. Intermediate directory closure preserves independent children, and the original root cannot close while its pins remain.

Eighteen new controls are authored and unrun: five compatibility codecs, five private-provider codecs and eight actual Ramfsd state/dispatch cases. Ramfsd's live-handle helper types and stale compatibility-minor fixture expectations are corrected from source observations. No compiler or test failure is claimed. Component contracts and maintained manual/API-reference source are updated, and Rustfmt was applied.

Full native open/openat remains open: native source preparation, VFS candidate ownership, other providers, Posixd serving, creation/append effects and native workloads are unfinished. No acquisition acceptance credit is added. Weighted completion remains 16.91%, with 21/460 parents and 441/902 sub-items complete. Both EriX guest-build generations and the external Rust/LLVM guest rebuild remain unfinished.

The exact conflicting constants and assertions are identified above. Preserve independent literal framing and existing malformed-length coverage. Test execution remains deferred by user instruction; authored source controls are not reported as passing.

Tracking

Owning review: #3. Related acquisition work: erix/posixd#17. Phase tracking: erix/integration#65.

## Summary The malformed-I/O test still expects supported compatibility minor 4 to be rejected, then restores obsolete minor 3 before expecting a successful header parse. Both expectations conflict with the published 1.4 codec. This is a source-observed test regression; no test or CI run was performed. ## Reproduction At revision `7ae4eeedb456d8d02057fab387b0e529df8a4c35`, inspect `VERSION_MINOR_V1` in `src/header.rs` and `exact_minor_and_declared_large_lengths_are_preserved` in `tests/io_wire_invalid.rs`. The codec accepts 4, the rejection list contains 4, and the later successful-header case selects 3. ## Expected and actual behavior Expected: accept the independent supported fixture, reject previous/future minors, then restore that same supported fixture before inspecting declared lengths. Actual in source: stale expectations invert the supported revision and prevent the length case from reaching its intended assertion. During the coordinated compatibility 1.5 change, update rejected revisions, explicitly establish the initial valid fixture, and restore its original minor bytes instead of another disconnected literal. ## Environment and identity - LibPosixABI branch `feature/posix-compat`, starting revision above. - Read-only source comparison during dynamic acquisition framing work. - No compiler, test, image, VM or CI failure is claimed. Runtime behavior is not changed by this fixture correction. ## Evidence and prior checks Conditional provider acquisition checkpoint: [lib-ipc `bb5df3d2`](https://git.erikinkinen.fi/erix/lib-ipc/commit/bb5df3d21da19e585b5e0d4128cc84e103b43398), [lib-posixabi `cdc6eb9e`](https://git.erikinkinen.fi/erix/lib-posixabi/commit/cdc6eb9ebac4f8dace25fa3e2e5c78a42b450e3d), [ramfsd `ba8ea6da`](https://git.erikinkinen.fi/erix/ramfsd/commit/ba8ea6daaa1d0c6caa1baafff266c20c29fce8ed), [docs `d470ea50`](https://git.erikinkinen.fi/erix/docs/commit/d470ea50be9cf5b70491c99140ba4aa0e71bd60f), [integration `b9acf76b`](https://git.erikinkinen.fi/erix/integration/commit/b9acf76bba4967a139eaf16d666c8d05eb261482), [rootd `27835abd`](https://git.erikinkinen.fi/erix/rootd/commit/27835abda0a1356824ea462269fce68f0c048cdc). Compatibility 1.5 now describes Open/openat with raw borrowed pathname bytes and checked independent base, access, lookup, shared-status, inheritance and creation-mode domains. Private provider acquisition/retirement framing retains an original root and acquisition identity before submission. Ramfsd compares actual parent permission evidence and pins no-follow files, directories or symlinks in one exclusive turn. Cleanup does not require the original handle reply; retirement fences delayed replay without tombstone storage. Intermediate directory closure preserves independent children, and the original root cannot close while its pins remain. Eighteen new controls are authored and unrun: five compatibility codecs, five private-provider codecs and eight actual Ramfsd state/dispatch cases. [Ramfsd's live-handle helper types](https://git.erikinkinen.fi/erix/ramfsd/issues/3) and [stale compatibility-minor fixture expectations](https://git.erikinkinen.fi/erix/lib-posixabi/issues/4) are corrected from source observations. No compiler or test failure is claimed. Component contracts and maintained manual/API-reference source are updated, and Rustfmt was applied. [Full native open/openat](https://git.erikinkinen.fi/erix/posixd/issues/17) remains open: native source preparation, VFS candidate ownership, other providers, Posixd serving, creation/append effects and native workloads are unfinished. No acquisition acceptance credit is added. Weighted completion remains 16.91%, with 21/460 parents and 441/902 sub-items complete. Both EriX guest-build generations and the external Rust/LLVM guest rebuild remain unfinished. The exact conflicting constants and assertions are identified above. Preserve independent literal framing and existing malformed-length coverage. Test execution remains deferred by user instruction; authored source controls are not reported as passing. ## Tracking Owning review: https://git.erikinkinen.fi/erix/lib-posixabi/pulls/3. Related acquisition work: https://git.erikinkinen.fi/erix/posixd/issues/17. Phase tracking: https://git.erikinkinen.fi/erix/integration/issues/65.
erikinkinen added this to the Alpha 1 milestone 2026-10-30 09:34:50 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erix/lib-posixabi#4
No description provided.