[BUG] Preserve other clients pending descriptors during terminal cleanup #18
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/posixd#18
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Descriptor terminal compaction requires every indexed binding to contain a description key before checking which client owns it. A different client's reserved new number may legitimately have no previous description while duplication is pending. Retiring an unrelated client therefore reports an internal state error instead of preserving that pending row.
Reproduction
Read the compaction loop in
src/descriptors/retirement.rsand the absent-target reservation insrc/descriptors/change.rs. Reserve duplication into a new number for one client, then retire another client with a live source. The compaction loop evaluates the first client's absent previous-description key before the client comparison.Expected and actual behavior
Expected: validate and dispose descriptions belonging to the terminal client, while copying other clients' index entries without interpreting their pending mutation state. The original pending duplication must remain finishable and retain all source holds.
Actual in source: the unconditional description-key requirement rejects that valid intermediate state. Move terminal description lookup inside the matching-client branch and add a cross-client pending-reservation regression control.
Environment and identity
feature/posix-compat, original signed descriptor implementation7c7e44d94d96b0c6c0574ac765047fd3eaa8e44f.Evidence and prior checks
Dynamic acquisition reservation checkpoint — 29 September 2026: posixd
947d9852, docse9cd7b00, integration730f6f1a.Local fd and shared-description capacity is now reserved together before external acquisition. Pending numbers cannot perform I/O, and the empty source row retains its reserving process. Publication/cancellation correlates both complete generations; peer index changes and stale tokens cannot select a successor. Configured initial source installation uses the same implementation. The cross-client terminal compaction defect is fixed by interpreting descriptions only for the terminal client, preserving another client's pending new duplicate and original source hold.
Five new reservation controls and one cross-client regression control are authored and unrun. Component architecture/roadmaps, the descriptor contract and maintained manual TeX are updated. Three signed commits and three catalog selectors are published; the independent Rust-helper identity is unchanged. Rustfmt was applied. Tests, builds, lint checks, manual/Rustdoc generation, VM/profiler execution and CI observation remain deferred by user instruction.
The complete open/openat acquisition issue remains open. Native source preparation, conditional provider traversal/effects, actual sealed-client dispatch and the complete native workload are still implementation work. This checkpoint adds no checklist completion credit: weighted progress remains 16.91%, with 21/460 parent items and 441/902 sub-items accepted. No execution pass or dynamic open success is claimed.
The retained mutation constructor deliberately uses an absent description for a new pending target. Terminal compaction currently unwraps that description before checking the client. Existing controls cover pending mutation for the same terminal client; add the separate-client case and retain original cleanup evidence and ordering.
Tests and CI observation remain deferred by user instruction. Do not claim execution success from the source correction.
Tracking
Owning review: #5. Descriptor ownership: #15. Ongoing acquisition: #17. Phase tracking: erix/integration#65.
erikinkinen referenced this issue2026-09-29 18:39:49 +02:00
erikinkinen referenced this issue from erix/docs2026-09-29 18:39:50 +02:00
erikinkinen referenced this issue from erix/integration2026-09-29 18:39:51 +02:00