[BUG] Native candidate operations omit selected mount policy #11
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/vfsd#11
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Implemented and published: native candidate operations enforce the selected mount's read-only policy independently of the acquisition scope's write ceiling. Read-only candidate reads omit clock queries and access-time updates. The correction is Vfsd
4658bef7; the corresponding filesystem manual is updated.The previous candidate path omitted the mount check during write evidence and admission. Candidate reads also obtained a timestamp unconditionally, unlike existing mount-aware read paths. Bound-directory write-access evidence needed the same mount restriction.
Reproduction
Source-derived reproduction; it has not been executed. Prepare an explicitly writable acquisition scope over a read-only mounted filesystem and acquire an existing file. Query write permission, request write or read/write admission (with and without truncation), and read through an admitted read candidate. Compare provider calls, clock queries, original bytes and retained cleanup owners.
The authored controls are in
src/acquisition_scope/mount_policy_tests.rs. They also inject a stricter mount view after successful admission to check positioned/append writes and surviving read access; this fixture does not imply a runtime remount API.src/exact_permissions_tests.rsextends the real bound-directory dispatcher control to read-only mounts.Expected and actual behavior
Expected: mount restrictions intersect original scope and descriptor access before provider work. Read-only reads succeed without requesting metadata changes or clock evidence. Denied writes, including empty writes, do not mutate bytes. Local refusal preserves admitted read access and original-key cleanup, including a temporarily busy retirement.
Prior source behavior: scope authority was checked without the selected mount flag, while the candidate adapter queried time even on read-only mounts. Provider-specific refusal could mask the VFS omission; no deployed bypass or runtime reproduction is claimed.
Implemented behavior: shared mount admission precedes evidence, admission and each write. VFS selects timestamps and adapters only forward them. Writable nonempty operations retain trusted time; clock/provider failures after entering the operation boundary retain cleanup-only custody without replay.
Environment and identity
374065f38ddb5ad82e3ca6f3c76580a946431829onfeature/posix-compat.4658bef704c6c26cfadf43034e4b8d9fc0fdcc44; unchanged IPC and Cargo identities.50666ac469d9e342c567b066fa3b5d667f1f2da1before adoption of the correction.Evidence and prior checks
The native candidate mount-policy defect is corrected and published: docs
c6fe35cf, vfsd4658bef7, integrationba59428d.Candidate write evidence, final write admission, truncation and each positioned/append write intersect the original scope ceiling with the selected held object's mount policy before provider work. Bound-directory write-access evidence applies the same restriction. Empty writes still require native write authority. Local mount refusal preserves an admitted read alias and the original cleanup key; pending retirement still retains the actual provider pin.
Read-only candidate reads omit clock queries and access-time updates. VFS selects timestamps according to mount policy and operation intent, and provider adapters only forward that value. Writable nonempty read requests, nonempty writes and truncation retain trusted time. Empty requests omit it. Clock or provider failures after entering the original operation boundary retain cleanup-only custody without replay.
Four new focused regressions and an extended bound-directory control are authored and unrun. The fixture observes actual timestamped and ordinary provider wire calls, original bytes, denial without clock/provider effects and independently retained cleanup pins. Rustfmt was applied to 13 Rust inputs using repository settings. Component architecture/roadmaps, the custody contract and technical manual TeX are updated.
Three signed commits in Vfsd, Docs and Integration are pushed on feature/posix-compat, with remote head equality recorded. Integration adopts three catalog entries and retains independent Rust helper
0483017f598290a81af9f57dc3f937f390b1ec83. No Cargo source identities change. A read-only inventory covers 3499 code files in 76 repositories, all below 1000 lines; the largest changed source is 889 lines.Full native Open/openat remains open. Cross-mount transitions, symlink following and conditional creation with process umask remain unfinished. This correction adds no full Open acceptance credit. Recalculated progress is 16.91% weighted, 5.21% whole-item acceptance: 21/460 parents and 441/902 sub-items. Both complete EriX guest-build generations and the external Rust/LLVM guest rebuild remain required. Tests, builds, lint checks, documentation generation, VM/profiler execution and CI observation remain deferred. No execution pass, warning-free build or measured speedup is claimed.
Earlier evidence follows; the current correction above supersedes the earlier mount-policy behavior.
Four new focused regression tests and one extended existing control are authored and unrun. The provider fixture observes actual timestamped and non-timestamped wire requests, changed bytes and cleanup pins independently of VFS results. Repository rustfmt was applied. Signed commits are pushed and their remote branch heads read back.
Testing is waived by user instruction. Tests, builds, lint checks, documentation generation, VM/profiler execution and CI observation remain deferred. No execution pass, warning-free build or measured performance gain is claimed.
Tracking
Related: full native Open/openat, Vfsd implementation PR, Integration tracking. Cross-mount traversal, symlink following and conditional creation with process umask remain unfinished; this correction does not close full Open acceptance.
erikinkinen referenced this issue2026-09-30 01:37:18 +02:00
erikinkinen referenced this issue from erix/docs2026-09-30 01:37:19 +02:00
erikinkinen referenced this issue from erix/integration2026-09-30 01:37:20 +02:00