[BUG] Delayed candidate retirement repeats process-lock cleanup #26
Labels
No labels
alpha-1
bug
ci
docs
duplicate
enhancement
help wanted
invalid
performance
phase-6
question
refactor
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
erix/vfsd#26
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Delayed native candidate disposal repeats process-wide advisory-lock release after the original compatibility Close has already completed. This can remove later process locks or reservations held through another candidate for the same object. Candidate cleanup also leaves matching published intervals in retained rollback journals, allowing later cancellation to restore advisory records whose original pin has retired.
Reproduction
Source-derived sequences, not executed:
For rollback lifetime, hold a published process interval through A, prepare a conversion through B, retire A, and then cancel B's reservation. The journal must not restore A's retired custody.
Expected and actual behavior
Explicit Close releases process policy once. Delayed candidate disposal removes only lock records and reservations dependent on that original pin, including matching rollback contents. B's later records/reservations survive A's disposal, and cancellation cannot restore records held by A after its retirement.
Source inspection finds that retire_scoped_candidate calls retire_process_locks before narrow candidate cleanup; the broad helper clears every process record and reservation for the same object and scope. The narrow cleanup visits current intervals but does not remove matching journal.before intervals. No runtime reproduction or executed failure is claimed.
Environment and identity
01081c24c321e7ed44bcf48c1a1cfb96a9040c53onfeature/posix-compat; Integrationbdd4dc684906964b9dcdb966cc13334de85e99ed.Evidence and prior checks
Read-only inspection of
src/handles/acquisition/native.rs,src/handles/locks/lifetime.rs,src/handles/locks.rsand the native lock dispatch. Tests, builds, lint and CI observation are currently deferred by request. Regression controls will be authored without execution, using independent peer observations and accepted/cancelled reservation outcomes.Tracking
Supports retained local-stream and overlapping-call ownership and Phase 6 completion. Resolution requires removing repeated process-wide retirement, preserving separate process/description policies and preventing retired custody from surviving in rollback records.
Source resolution — 3 October 2026
No new native grant, provider route, allocation, wire operation or unsafe code is introduced.
This repair does not complete mediator admission coordination: uncertain explicit Close retries must not erase newly acquired process locks, and a blocking Wait must not hold a fence that deadlocks Close. Queued mutation admission, path-anchor/socket-path lifetime audit, invocation-owned masks, fair all-call intake/drain, native thread/TLS semantics, complete libc frontends and imported consumers remain unfinished. All eight whole socket criteria remain unchecked. Both full EriX guest generations AND external Rust/LLVM rebuilding inside EriX remain mandatory and unperformed.
Related records and contracts
erikinkinen referenced this issue2026-10-03 01:36:52 +02:00
erikinkinen referenced this issue from erix/docs2026-10-03 01:36:53 +02:00
erikinkinen referenced this issue from erix/integration2026-10-03 01:36:53 +02:00