Protocol: accept the declared diagnostic and source inventories #669

Open
erikinkinen wants to merge 12 commits from fix/protocol-2.2-closed-enums into main
Owner

Closes #666.

Current CI-only integration

Plan ID: BUG-666. Current integration head: 128fb39b072ed39fdb5e517775089c8b230a963e.
Selected predecessor: #108 / PR #668 at
145abd989a92f5707d03c339b411520009b57c83. Its current state is open;
predecessor acceptance is required before this PR's checklist and merge.

This signed update changes exactly the sanitizer overall timeout, its
documentation and two CI failure-evidence files. All original owned outputs,
integrated build configurations and source/acceptance/integration JSON records
are byte-identical. Existing source and local integration validations retain
their original execution heads and scope. The failed 90-minute attempts remain
failed attempts; this head requires all ten new final remote checks.

CI budget qualification, SHA-256
2a24aa55e60b193c315a3ebe1c39fc34717cadbf4f67f2a1b5041be6962d93e1, establishes full 496-test pinned-consumer capacity
for #670. This PR's complete 497-test suite still requires its own new remote
checks. No scientific input, parser/planner meaning, bound or estimand changed.

Original source and integration evidence

Task

Closes #666

Summary

Align the protocol 2.2 common envelope with its exact fifteen diagnostics and
twelve source IDs. Accept V5d and the five section-4.5 source IDs; reject
undeclared V2c and malformed near-neighbors in both native parsing and JSON Schema.

Scope

Included

  • Closed native/schema inventories, documentation and independent fixture coverage.
  • Regression controls preserving Phase2 planner ownership and canonical identity.

Explicitly excluded

  • Scientific protocol, endpoint, population, matrix, margin or qualification changes.

Design intent

The common envelope recognizes declared IDs across phases2–6. Later stage gates
still enforce applicability. The Phase2 diagnostic planner rejects every other
source and an appended V5d, with no output creation or workload execution.

Phase discipline

This fixes the accepted common-envelope implementation to the frozen protocol.
All historical acceptance records retain their original source identities.

Verification

Source 4e007880da782cdcd46c0e12741696cbf18e5e8e passes parser/schema and complete structural
planner fixtures in Release, Debug-O1 and Clang ASan/UBSan: 254 parser negative
cases, 28 planner negative cases, 40 config-schema negatives, all thirteen
stage dispatch cases and 13,104 complete planned rows/configurations. Eight
original baseline cases are retained and reexecuted under all three profiles;
the fixed expected outcomes and canonical stdout agree. Zero workloads execute.
Original failure and source evidence has SHA-256
ffc6dab648225fc90fc0484a70ed788545f3e5f1981e00813a857a1fc207ea70.

Integration a45096fd37c85362efcb697760b4e1b8a5363cce changes only six predecessor receipt JSON files relative
to the local source acceptance. All owned implementation/schema/docs/fixtures
and build files remain unchanged. The current497-test inventory is identical;
both focused tests pass afresh. All eight hooks and frozen scope checks pass.
Integration evidence has SHA-256
301fa26987c663c3b6bf07876facc7023b0ef891e70b2145fd6aefae14142f1a. Both complete final remote497-test suites and
the remaining six contexts are mandatory; no complete local497-test run is claimed.

Notes

This PR is queued behind PR #668 at fcbbdf6d088ccc39322d81e4aaae3dd4af9d14c6 to overlap CI.
Until it merges, the comparison with main includes the pending predecessor
stack. Require its accepted exact-head CI and closed issue #108, then all ten
own final exact-head contexts. Only afterward check all three issue #666 items
once and perform the guarded signed fast-forward merge. Native #107 is closed.

Acceptance record completion

Signed head 8712d6b0ddd80fcc2ff311c074f1c3eaca0b73cb adds section17.4's required commands inventory from
eleven already archived successful command records.
acceptance-completion.json verifies their original log hashes and preserves
all implementation, schema, fixture and original integration-receipt bytes.
No additional source validation is claimed. All ten final contexts are required
on this new head before the three issue items can be checked once.

Closes #666. ## Current CI-only integration Plan ID: `BUG-666`. Current integration head: `128fb39b072ed39fdb5e517775089c8b230a963e`. Selected predecessor: #108 / PR #668 at `145abd989a92f5707d03c339b411520009b57c83`. Its current state is `open`; predecessor acceptance is required before this PR's checklist and merge. This signed update changes exactly the sanitizer overall timeout, its documentation and two CI failure-evidence files. All original owned outputs, integrated build configurations and source/acceptance/integration JSON records are byte-identical. Existing source and local integration validations retain their original execution heads and scope. The failed 90-minute attempts remain failed attempts; this head requires all ten new final remote checks. [CI budget qualification](https://git.erikinkinen.fi/attachments/be11a4e4-bb34-4091-b506-7f06e86db24d), SHA-256 `2a24aa55e60b193c315a3ebe1c39fc34717cadbf4f67f2a1b5041be6962d93e1`, establishes full 496-test pinned-consumer capacity for #670. This PR's complete 497-test suite still requires its own new remote checks. No scientific input, parser/planner meaning, bound or estimand changed. ## Original source and integration evidence # Task Closes #666 ## Summary Align the protocol 2.2 common envelope with its exact fifteen diagnostics and twelve source IDs. Accept V5d and the five section-4.5 source IDs; reject undeclared V2c and malformed near-neighbors in both native parsing and JSON Schema. ## Scope ### Included - Closed native/schema inventories, documentation and independent fixture coverage. - Regression controls preserving Phase2 planner ownership and canonical identity. ### Explicitly excluded - Scientific protocol, endpoint, population, matrix, margin or qualification changes. ## Design intent The common envelope recognizes declared IDs across phases2–6. Later stage gates still enforce applicability. The Phase2 diagnostic planner rejects every other source and an appended V5d, with no output creation or workload execution. ## Phase discipline This fixes the accepted common-envelope implementation to the frozen protocol. All historical acceptance records retain their original source identities. ## Verification Source `4e007880da782cdcd46c0e12741696cbf18e5e8e` passes parser/schema and complete structural planner fixtures in Release, Debug-O1 and Clang ASan/UBSan: 254 parser negative cases, 28 planner negative cases, 40 config-schema negatives, all thirteen stage dispatch cases and 13,104 complete planned rows/configurations. Eight original baseline cases are retained and reexecuted under all three profiles; the fixed expected outcomes and canonical stdout agree. Zero workloads execute. [Original failure and source evidence](https://git.erikinkinen.fi/attachments/1e6919f4-91e4-4d70-9c46-514c8b317887) has SHA-256 `ffc6dab648225fc90fc0484a70ed788545f3e5f1981e00813a857a1fc207ea70`. Integration `a45096fd37c85362efcb697760b4e1b8a5363cce` changes only six predecessor receipt JSON files relative to the local source acceptance. All owned implementation/schema/docs/fixtures and build files remain unchanged. The current497-test inventory is identical; both focused tests pass afresh. All eight hooks and frozen scope checks pass. [Integration evidence](https://git.erikinkinen.fi/attachments/2356d53b-6b34-4f79-ab8e-d097725e2341) has SHA-256 `301fa26987c663c3b6bf07876facc7023b0ef891e70b2145fd6aefae14142f1a`. Both complete final remote497-test suites and the remaining six contexts are mandatory; no complete local497-test run is claimed. ## Notes This PR is queued behind PR #668 at `fcbbdf6d088ccc39322d81e4aaae3dd4af9d14c6` to overlap CI. Until it merges, the comparison with main includes the pending predecessor stack. Require its accepted exact-head CI and closed issue #108, then all ten own final exact-head contexts. Only afterward check all three issue #666 items once and perform the guarded signed fast-forward merge. Native #107 is closed. ## Acceptance record completion Signed head `8712d6b0ddd80fcc2ff311c074f1c3eaca0b73cb` adds section17.4's required commands inventory from eleven already archived successful command records. `acceptance-completion.json` verifies their original log hashes and preserves all implementation, schema, fixture and original integration-receipt bytes. No additional source validation is claimed. All ten final contexts are required on this new head before the three issue items can be checked once. <!-- ci-only-refresh-666-128fb39b072ed39fdb5e517775089c8b230a963e -->
erikinkinen added this to the Phase 2 milestone 2026-10-27 02:21:34 +01:00
Phase 2: record survival integration identity and exact test union
Some checks failed
clang-format / check-format (pull_request) Successful in 1m4s
markdownlint / markdown-lint (pull_request) Successful in 1m4s
formal / definitions (pull_request) Successful in 2m4s
ci / smoke (pull_request) Successful in 21m56s
ci / sanitizers (pull_request) Successful in 1h1m35s
clang-format / check-format (push) Successful in 1m18s
markdownlint / markdown-lint (push) Successful in 1m26s
ci / sanitizers (push) Has been cancelled
ci / smoke (push) Has been cancelled
formal / definitions (push) Has been cancelled
f6c256a580
# Conflicts:
#	research/CMakeLists.txt
Phase 2: record pinned kernel environment integration evidence
All checks were successful
clang-format / check-format (pull_request) Successful in 1m18s
markdownlint / markdown-lint (pull_request) Successful in 1m29s
formal / definitions (pull_request) Successful in 3m2s
ci / smoke (pull_request) Successful in 22m20s
ci / sanitizers (pull_request) Successful in 1h6m9s
clang-format / check-format (push) Successful in 1m35s
formal / definitions (push) Successful in 3m8s
markdownlint / markdown-lint (push) Successful in 1m32s
ci / smoke (push) Successful in 26m20s
ci / sanitizers (push) Successful in 1h0m36s
a0e85a1bc5
Phase 2: record paired-control integration and complete test union
Some checks failed
markdownlint / markdown-lint (push) Successful in 1m10s
clang-format / check-format (push) Successful in 1m33s
formal / definitions (push) Successful in 2m37s
clang-format / check-format (pull_request) Successful in 1m28s
markdownlint / markdown-lint (pull_request) Successful in 1m36s
formal / definitions (pull_request) Successful in 3m7s
ci / smoke (push) Successful in 41m35s
ci / smoke (pull_request) Successful in 41m37s
ci / sanitizers (push) Failing after 1h30m13s
ci / sanitizers (pull_request) Failing after 1h30m17s
ab30f63657
Phase 2: record canonical run-manifest integration evidence
Some checks failed
clang-format / check-format (push) Successful in 2m3s
formal / definitions (push) Successful in 2m49s
markdownlint / markdown-lint (push) Successful in 1m4s
clang-format / check-format (pull_request) Successful in 1m52s
formal / definitions (pull_request) Successful in 3m7s
markdownlint / markdown-lint (pull_request) Successful in 1m10s
ci / smoke (push) Successful in 41m3s
ci / smoke (pull_request) Successful in 41m51s
ci / sanitizers (push) Failing after 1h30m16s
ci / sanitizers (pull_request) Failing after 1h30m8s
fcbbdf6d08
BUG-666: record source-preserving integration evidence
Some checks failed
clang-format / check-format (push) Successful in 1m45s
markdownlint / markdown-lint (push) Successful in 1m12s
formal / definitions (push) Successful in 2m59s
ci / sanitizers (push) Has been cancelled
ci / smoke (push) Has been cancelled
ci / smoke (pull_request) Has been cancelled
ci / sanitizers (pull_request) Has been cancelled
clang-format / check-format (pull_request) Has been cancelled
formal / definitions (pull_request) Has been cancelled
markdownlint / markdown-lint (pull_request) Has been cancelled
a214b01cbc
BUG-666: complete required archived command inventory
Some checks failed
clang-format / check-format (push) Successful in 1m27s
clang-format / check-format (pull_request) Successful in 1m26s
formal / definitions (push) Successful in 2m32s
markdownlint / markdown-lint (push) Successful in 1m19s
markdownlint / markdown-lint (pull_request) Successful in 1m20s
formal / definitions (pull_request) Successful in 3m1s
ci / smoke (push) Successful in 39m7s
ci / smoke (pull_request) Successful in 38m51s
ci / sanitizers (push) Failing after 1h30m8s
ci / sanitizers (pull_request) Failing after 1h30m5s
8712d6b0dd
Phase 2: integrate validated sanitizer budget into run manifests
All checks were successful
markdownlint / markdown-lint (pull_request) Successful in 38s
markdownlint / markdown-lint (push) Successful in 39s
clang-format / check-format (pull_request) Successful in 59s
clang-format / check-format (push) Successful in 1m3s
formal / definitions (push) Successful in 2m23s
formal / definitions (pull_request) Successful in 2m25s
ci / smoke (pull_request) Successful in 40m7s
ci / smoke (push) Successful in 41m41s
ci / sanitizers (pull_request) Successful in 2h16m9s
ci / sanitizers (push) Successful in 2h16m30s
145abd989a
Phase 2: integrate sanitizer budget into protocol enum correction
All checks were successful
clang-format / check-format (push) Successful in 1m8s
formal / definitions (push) Successful in 2m15s
markdownlint / markdown-lint (push) Successful in 51s
clang-format / check-format (pull_request) Successful in 1m10s
markdownlint / markdown-lint (pull_request) Successful in 1m2s
formal / definitions (pull_request) Successful in 2m36s
ci / smoke (push) Successful in 40m45s
ci / smoke (pull_request) Successful in 40m33s
ci / sanitizers (push) Successful in 2h15m58s
ci / sanitizers (pull_request) Successful in 2h15m31s
128fb39b07
All checks were successful
clang-format / check-format (push) Successful in 1m8s
Required
Details
formal / definitions (push) Successful in 2m15s
Required
Details
markdownlint / markdown-lint (push) Successful in 51s
Required
Details
clang-format / check-format (pull_request) Successful in 1m10s
Required
Details
markdownlint / markdown-lint (pull_request) Successful in 1m2s
Required
Details
formal / definitions (pull_request) Successful in 2m36s
Required
Details
ci / smoke (push) Successful in 40m45s
Required
Details
ci / smoke (pull_request) Successful in 40m33s
Required
Details
ci / sanitizers (push) Successful in 2h15m58s
Required
Details
ci / sanitizers (pull_request) Successful in 2h15m31s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'fix/protocol-2.2-closed-enums:fix/protocol-2.2-closed-enums'
git switch 'fix/protocol-2.2-closed-enums'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
erikinkinen/AES!669
No description provided.